From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84579C7EE2F for ; Tue, 6 Jun 2023 23:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=flzo6cDQKKM/aBnBT7cATnu2fYJhAz3X2pA5KXGJWIs=; b=3NlqeKXdAWLBp7 /3zPZO0V7eXIFWr/ZynyqrZU2KOaCxmwHj2YiKvVO/IP1LnR3Fde7pD6vnQkgUKSiinmwGJziFhDT yb/3KkeOD3YL+WU+SItwYmqrkhkZobKep3SbmFHUnTpcjtpcUU0NIptBdS4OxSupvsG1abJ1pRqrX XoAa1gfiwq5nscKxF6CrLz6BKgmSg+ZP7J9RRin8r4+wQ3g457/Yx2uge9Otdsza3DOAiVwiz/xST vVtM4YQQXuYcUnBLVJSqtzeCT4P20Tp4MsepN1E4hzz2h0jHPTyou4bSzuXJWd+/y++lJ8M8HgQcd EjKuH5gceLJ4YU9Ux/ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6ffo-003YNM-1f; Tue, 06 Jun 2023 23:01:08 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6ffj-003YJS-21 for linux-mtd@lists.infradead.org; Tue, 06 Jun 2023 23:01:06 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f6dfc4dffaso56780515e9.0 for ; Tue, 06 Jun 2023 16:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20221208.gappssmtp.com; s=20221208; t=1686092460; x=1688684460; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4AyxSeVCWLu668XQQXcZmNRbTvqm+XfWnbYRI3bfM+o=; b=ap+1NYchKGrYc446kRWRnQbhMV1pl6YsP5OToBbRr7yqxWuwivol/KLqvKwbFREzDt leVawKb5LA6xL6S30/x70zQDywvhkHn7+JCGlKA0lozFIJqWnjRJTp5YJHpex7lWnnUv dJkg9spKjZLznLO62AffDpdqoqWcUVXi8VRvJ792SrSPG5RfZag3TIQLuMV3b7gUNrfh oTcGuFKfS4159jodmD3xpY5/Ko+Rh5RiDBfrQUvcEy89mqnn+LVVNO5Iw2N5Qiu+JIlB FJKkwHEgGck4KgrxHNc30tLse+VJntfkb30BZScrTrWOpflbR4XFpuj885jYKqOuXNkW SBWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686092460; x=1688684460; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4AyxSeVCWLu668XQQXcZmNRbTvqm+XfWnbYRI3bfM+o=; b=DkVzPm4B0cr2tSNYuQk5T6KfjJZ/0Kv+OO/xzbXoehoSV6QKZmTLz4hQYgKrgDRoqD P0U5D+SNmhry28I/RKjtO82L5AN8Go6uerF3Os9AHzElUbruA/Eqf1jBfWwCgZDeB9sv P109QQZuHZCPxYznkDpyOuJ8p/fdjHHPCcb9C6HdxFTiI+o0XnlvfIAvTiT07X2YQ+Cw CB6Gi+ct2qSc6h5t1jfZJDk8pKPTP7QVe9ZXmhGEdlyM2MA/v+ZjGE/+MbNhDUj3OUwo a6ZDGHxn3fNLPnfSF6QLvmK08VxEoMhG1exfVj98efPRV1Pm5uPW2n59vqKG9EFEdNGd dSqg== X-Gm-Message-State: AC+VfDx2UkOK8voq0kKT26S0YFSAKnJbcu3YmGN/G+pNMWpRfC5tLTLY 71hxLQnACWwgo2F+z35ctQp7uQ== X-Google-Smtp-Source: ACHHUZ5ZvgvojXp46B2yfDhTglh07h4ImH+yrfGSyDnf68I9NldGnBlDJsUdFl1IxgkatnTdfmUXtg== X-Received: by 2002:a1c:4c0d:0:b0:3f5:6e6:9d83 with SMTP id z13-20020a1c4c0d000000b003f506e69d83mr2830681wmf.23.1686092459976; Tue, 06 Jun 2023 16:00:59 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id u25-20020a7bcb19000000b003f73a101f88sm201447wmj.16.2023.06.06.16.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 16:00:59 -0700 (PDT) Date: Wed, 7 Jun 2023 00:00:57 +0100 From: Phillip Potter To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release Message-ID: References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-7-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230606073950.225178-7-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230606_160105_529623_8626D111 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/cdrom/cdrom.c | 2 +- > drivers/cdrom/gdrom.c | 2 +- > drivers/scsi/sr.c | 2 +- > include/linux/cdrom.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > index adebac1bd210d9..998b03fe976e22 100644 > --- a/drivers/cdrom/cdrom.c > +++ b/drivers/cdrom/cdrom.c > @@ -1250,7 +1250,7 @@ static int check_for_audio_disc(struct cdrom_device_info *cdi, > return 0; > } > > -void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode) > +void cdrom_release(struct cdrom_device_info *cdi) > { > const struct cdrom_device_ops *cdo = cdi->ops; > > diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c > index 14922403983e9e..a401dc4218a998 100644 > --- a/drivers/cdrom/gdrom.c > +++ b/drivers/cdrom/gdrom.c > @@ -481,7 +481,7 @@ static int gdrom_bdops_open(struct block_device *bdev, fmode_t mode) > bdev_check_media_change(bdev); > > mutex_lock(&gdrom_mutex); > - ret = cdrom_open(gd.cd_info, mode); > + ret = cdrom_open(gd.cd_info); > mutex_unlock(&gdrom_mutex); > return ret; > } > diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c > index 444c7efc14cba7..6d33120ee5ba85 100644 > --- a/drivers/scsi/sr.c > +++ b/drivers/scsi/sr.c > @@ -512,7 +512,7 @@ static void sr_block_release(struct gendisk *disk, fmode_t mode) > struct scsi_cd *cd = scsi_cd(disk); > > mutex_lock(&cd->lock); > - cdrom_release(&cd->cdi, mode); > + cdrom_release(&cd->cdi); > mutex_unlock(&cd->lock); > > scsi_device_put(cd->device); > diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h > index 385e94732b2cf1..3f23d5239de254 100644 > --- a/include/linux/cdrom.h > +++ b/include/linux/cdrom.h > @@ -102,7 +102,7 @@ int cdrom_read_tocentry(struct cdrom_device_info *cdi, > > /* the general block_device operations structure: */ > int cdrom_open(struct cdrom_device_info *cdi, fmode_t mode); > -extern void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode); > +void cdrom_release(struct cdrom_device_info *cdi); > int cdrom_ioctl(struct cdrom_device_info *cdi, struct block_device *bdev, > unsigned int cmd, unsigned long arg); > extern unsigned int cdrom_check_events(struct cdrom_device_info *cdi, > -- > 2.39.2 > Looks good, thanks. Signed-off-by: Phillip Potter Regards, Phil ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/