Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

Phillip Potter
2023-06-08T08:47:47Z

On Thu, Jun 08, 2023 at 10:41:29AM +0200, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 12:00:57AM +0100, Phillip Potter wrote:
> > Looks good, thanks.
> >
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
>
> Hmm, these signoffs don't really make sense here. Were they intended
> as Reviewed-bys?
>
Hi Christoph,

Yes indeed - I was under the impression it was appropriate for a
maintainer to signal their approval of a patch to maintained code using
a Signed-off-by tag due to their involvement in the submission process?
Apologies if I've got this wrong, happy to send Reviewed-bys by all
means.

Regards,
Phil