Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change

Hannes Reinecke
2023-06-07T13:19:19Z

On 6/7/23 14:21, Christoph Hellwig wrote:
> On Wed, Jun 07, 2023 at 02:19:00PM +0200, Hannes Reinecke wrote:
>>> - return true;
>>> + return __disk_check_media_change(disk,
>>> + disk_clear_events(disk, DISK_EVENT_MEDIA_CHANGE |
>>> + DISK_EVENT_EJECT_REQUEST));
>>
>> Can you move the call to disk_clear_events() out of the call to
>> __disk_check_media_change()?
>> I find this pattern hard to read.
>
> I suspect you've not done enough functional programming in your youth :)

That's why I said 'I find'; purely personal preference.
If you're happy with:

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
(In my youth? One is tempted to quote Falco: "If you remember the '90s
you haven't experienced them...")