Re: [PATCH 25/31] ubd: remove commented out code in ubd_open

Richard Weinberger
2023-06-06T08:21:26Z

----- Ursprüngliche Mail -----
> Von: "hch" <hch@lst.de>
> This code has been dead forever, make sure it doesn't show up in code
> searches.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/um/drivers/ubd_kern.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
> index 8b79554968addb..20c1a16199c503 100644
> --- a/arch/um/drivers/ubd_kern.c
> +++ b/arch/um/drivers/ubd_kern.c
> @@ -1170,13 +1170,6 @@ static int ubd_open(struct gendisk *disk, fmode_t mode)
> }
> ubd_dev->count++;
> set_disk_ro(disk, !ubd_dev->openflags.w);
> -
> - /* This should no more be needed. And it didn't work anyway to exclude
> - * read-write remounting of filesystems.*/
> - /*if((mode & FMODE_WRITE) && !ubd_dev->openflags.w){
> - if(--ubd_dev->count == 0) ubd_close_dev(ubd_dev);
> - err = -EROFS;
> - }*/

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard