From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCECBEB64DC for ; Thu, 20 Jul 2023 16:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgB7J2PuMiAaoucqxazSkNjf/dbhuCBmsV3JUSav4Ew=; b=FGS4zgEuV1NQ2/ BcjxKzm8/YCpKQ+aYWM6zgqJXR7WkYkXrhyH+9/uvJOOPtdKEAebb2zOtLhGFB6v1wYRjRzxmY1NF 2oI1mI8L8cuOZoRg5m35i+raynz5nEO8XzlHjPY70zRTVmsL2+6hUU5DnlR30ORCh46NzeNaXIk6G poILzjBUcR1+ngIK4GIgYU0SQwYNjpc1mnfY7EdMfpVIWMxdqpAoFrZ+lbDgAPq9ZWYZX9tByykqA ZabZvQruRUf5gI9PcxE7a8zpk7AdFil04dP50+7u8zoAiQDBnGZY4ELBi+swu+MFc5d8oYYhoVHuZ 0K3PfvPW6KyNCIsFm7dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMW8o-00Bd8h-2w; Thu, 20 Jul 2023 16:04:34 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMW8m-00Bd7c-33 for linux-mtd@lists.infradead.org; Thu, 20 Jul 2023 16:04:34 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qMW70-0004pa-2K; Thu, 20 Jul 2023 16:02:42 +0000 Date: Thu, 20 Jul 2023 17:02:32 +0100 From: Daniel Golle To: Christoph Hellwig Cc: Jens Axboe , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Dave Chinner , Matthew Wilcox , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Jan Kara , Damien Le Moal , Ming Lei , Min Li , Christian Loehle , Adrian Hunter , Hannes Reinecke , Jack Wang , Florian Fainelli , Yeqi Fu , Avri Altman , Hans de Goede , Ye Bin , Greg Kroah-Hartman , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [RFC PATCH 6/6] block: implement NVMEM provider Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230720_090432_983802_F069C840 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, Jul 20, 2023 at 12:04:43AM -0700, Christoph Hellwig wrote: > The layering here is exactly the wrong way around. This block device > as nvmem provide has not business sitting in the block layer and being > keyed ff the gendisk registration. Instead you should create a new > nvmem backed that opens the block device as needed if it fits your > OF description without any changes to the core block layer. > Ok. I will use a class_interface instead. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/