From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E69A0C0015E for ; Fri, 21 Jul 2023 16:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vs5AmuNF8MYHkBoEaV3Ieu8grD0VQ1sKJ688H7PulrI=; b=0nq6qdxAqNDIkz /KC1WrDakgfhKfCIylNx9uKBbC1KX6R5Xpx3z31lA4vUfge+Bi9mnd3WUaQy8KFsWQAfbjscnjQBh W/z+LL5/NJf2INC3GcbeP76GZFUR9Qf1S18oNH3L40I60FoYXAJ1irCxeQnsLwLurUdbRTCLJ71DN K0ubH10FX1k1rq39DqRhfeS2fz7h/ZYJh5weLIIrM+vMjQzzw02fZAWX3qfI9LAWyiDvI2A0FLbcv BEtkpJUniFwNoZjxUbd2LxuCSVoVMhatVlunJgXN3zF8sOofjh5QNbtMV/nxb3ycfZuU4ifrXzE8t ctwJ/eO1UCbEVLy28HWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMt97-00Ec6U-03; Fri, 21 Jul 2023 16:38:25 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMt92-00Ec5X-1N; Fri, 21 Jul 2023 16:38:21 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="364526936" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="364526936" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 09:38:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="760008775" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="760008775" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 21 Jul 2023 09:38:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMt8h-00Cn64-1u; Fri, 21 Jul 2023 19:37:59 +0300 Date: Fri, 21 Jul 2023 19:37:59 +0300 From: Andy Shevchenko To: nikita.shubin@maquefel.me Cc: Hartley Sweeten , Lennert Buytenhek , Alexander Sverdlin , Russell King , Lukasz Majewski , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Daniel Lezcano , Thomas Gleixner , Alessandro Zummo , Alexandre Belloni , Wim Van Sebroeck , Guenter Roeck , Sebastian Reichel , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mark Brown , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Damien Le Moal , Sergey Shtylyov , Dmitry Torokhov , Arnd Bergmann , Olof Johansson , soc@kernel.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Michael Peters , Kris Bahnsen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, linux-ide@vger.kernel.org, linux-input@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset Message-ID: References: <20230605-ep93xx-v3-0-3d63a5f1103e@maquefel.me> <20230605-ep93xx-v3-14-3d63a5f1103e@maquefel.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230605-ep93xx-v3-14-3d63a5f1103e@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_093820_475281_C565A35A X-CRM114-Status: GOOD ( 20.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, Jul 20, 2023 at 02:29:14PM +0300, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin > > Implement the reset behaviour of the various EP93xx SoCS in drivers/power/reset. > > It used to be located in arch/arm/mach-ep93xx. ... > +// SPDX-License-Identifier: (GPL-2.0) Are you sure this is correct form? Have you checked your patches? ... > +#include Do you need this? Or maybe you need another (of*.h) one? ... > + /* Issue the reboot */ > + ep93xx_devcfg_set_clear(priv->map, EP93XX_SYSCON_DEVCFG_SWRST, 0x00); > + ep93xx_devcfg_set_clear(priv->map, 0x00, EP93XX_SYSCON_DEVCFG_SWRST); > + mdelay(1000); Atomic?! Such a huge delay must be explained, esp. why it's atomic. > + pr_emerg("Unable to restart system\n"); > + return NOTIFY_DONE; ... > + err = register_restart_handler(&priv->restart_handler); > + if (err) > + return dev_err_probe(dev, err, "can't register restart notifier\n"); > + return err; return 0; -- With Best Regards, Andy Shevchenko ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/