public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion
@ 2023-06-15 16:42 Andy Shevchenko
  2023-06-15 22:10 ` Martin Blumenstingl
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2023-06-15 16:42 UTC (permalink / raw)
  To: Miquel Raynal, JaimeLiao, Martin Blumenstingl,
	Uwe Kleine-König, linux-mtd, linux-kernel
  Cc: Richard Weinberger, Vignesh Raghavendra, Andy Shevchenko

The of_gpio.h is not and shouldn't be used in the drivers. Remove it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mtd/nand/raw/nand_base.c | 1 -
 drivers/mtd/nand/raw/xway_nand.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index a6af521832aa..132e3bee8f5a 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -42,7 +42,6 @@
 #include <linux/io.h>
 #include <linux/mtd/partitions.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/gpio/consumer.h>
 
 #include "internals.h"
diff --git a/drivers/mtd/nand/raw/xway_nand.c b/drivers/mtd/nand/raw/xway_nand.c
index 6b1e2a2bba15..5a19b6b314b4 100644
--- a/drivers/mtd/nand/raw/xway_nand.c
+++ b/drivers/mtd/nand/raw/xway_nand.c
@@ -6,7 +6,6 @@
  */
 
 #include <linux/mtd/rawnand.h>
-#include <linux/of_gpio.h>
 #include <linux/of_platform.h>
 
 #include <lantiq_soc.h>
-- 
2.40.0.1.gaa8946217a0b


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion
  2023-06-15 16:42 [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion Andy Shevchenko
@ 2023-06-15 22:10 ` Martin Blumenstingl
  2023-07-10 10:00   ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Martin Blumenstingl @ 2023-06-15 22:10 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Miquel Raynal, JaimeLiao, Uwe Kleine-König, linux-mtd,
	linux-kernel, Richard Weinberger, Vignesh Raghavendra

On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion
  2023-06-15 22:10 ` Martin Blumenstingl
@ 2023-07-10 10:00   ` Andy Shevchenko
  2023-10-06 15:14     ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2023-07-10 10:00 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: Miquel Raynal, JaimeLiao, Uwe Kleine-König, linux-mtd,
	linux-kernel, Richard Weinberger, Vignesh Raghavendra

On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:
> On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Thank you!

Can it be applied now?

-- 
With Best Regards,
Andy Shevchenko



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion
  2023-07-10 10:00   ` Andy Shevchenko
@ 2023-10-06 15:14     ` Andy Shevchenko
  2023-10-06 15:41       ` Miquel Raynal
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2023-10-06 15:14 UTC (permalink / raw)
  Cc: Miquel Raynal, JaimeLiao, Uwe Kleine-König, linux-mtd,
	linux-kernel, Richard Weinberger, Vignesh Raghavendra

+Cc: GPIO maintainers

On Mon, Jul 10, 2023 at 01:00:51PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:
> > On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> Thank you!
> 
> Can it be applied now?

So, this is still not applied, does it mean we need to go via GPIO tree
with it?

-- 
With Best Regards,
Andy Shevchenko



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion
  2023-10-06 15:14     ` Andy Shevchenko
@ 2023-10-06 15:41       ` Miquel Raynal
  0 siblings, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2023-10-06 15:41 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: JaimeLiao, Uwe Kleine-König, linux-mtd, linux-kernel,
	Richard Weinberger, Vignesh Raghavendra

Hi Andy,

andriy.shevchenko@linux.intel.com wrote on Fri, 6 Oct 2023 18:14:24
+0300:

> +Cc: GPIO maintainers
> 
> On Mon, Jul 10, 2023 at 01:00:51PM +0300, Andy Shevchenko wrote:
> > On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:  
> > > On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:  
> > > >
> > > > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>  
> > > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>  
> > 
> > Thank you!
> > 
> > Can it be applied now?  
> 
> So, this is still not applied, does it mean we need to go via GPIO tree
> with it?

I remember your ping and also answering it, but I cannot find it. Let
me look into this. In any case, apologies for that.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-10-06 15:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-15 16:42 [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion Andy Shevchenko
2023-06-15 22:10 ` Martin Blumenstingl
2023-07-10 10:00   ` Andy Shevchenko
2023-10-06 15:14     ` Andy Shevchenko
2023-10-06 15:41       ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox