From: andy.shevchenko@gmail.com
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Christophe Kerello <christophe.kerello@foss.st.com>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Daniel Golle <daniel@makrotopia.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Johan Jonker <jbx6244@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v7 20/39] mtd: rawnand: add support for ts72xx
Date: Sun, 4 Feb 2024 18:49:45 +0200 [thread overview]
Message-ID: <Zb_AKQEBUB4Yg7JI@surfacebook.localdomain> (raw)
In-Reply-To: <20240118-ep93xx-v7-20-d953846ae771@maquefel.me>
Thu, Jan 18, 2024 at 11:21:03AM +0300, Nikita Shubin kirjoitti:
> Technologic Systems has it's own nand controller implementation in CPLD.
...
> +err_clean_nand:
> + nand_cleanup(&data->chip);
> +err_handle_put:
> + fwnode_handle_put(child);
> + return err;
> +}
> +
> +static void ts72xx_nand_remove(struct platform_device *pdev)
> +{
> + struct ts72xx_nand_data *data = platform_get_drvdata(pdev);
> + struct nand_chip *chip = &data->chip;
> + int ret;
> +
> + ret = mtd_device_unregister(nand_to_mtd(chip));
> + WARN_ON(ret);
> + nand_cleanup(chip);
Missing fwnode_handle_put()?
> +}
--
With Best Regards,
Andy Shevchenko
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-02-04 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:20 [PATCH v7 00/39] ep93xx device tree conversion Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 19/39] dt-bindings: mtd: Add ts7200 nand-controller Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 20/39] mtd: rawnand: add support for ts72xx Nikita Shubin via B4 Relay
2024-02-04 16:49 ` andy.shevchenko [this message]
2024-01-18 9:30 ` [PATCH v7 00/39] ep93xx device tree conversion Uwe Kleine-König
2024-01-18 9:36 ` Nikita Shubin
2024-02-04 17:03 ` andy.shevchenko
2024-02-13 9:48 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb_AKQEBUB4Yg7JI@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=christophe.kerello@foss.st.com \
--cc=daniel@makrotopia.org \
--cc=jbx6244@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=nikita.shubin@maquefel.me \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox