From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75C9EC25B78 for ; Thu, 16 May 2024 11:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/mSDGmu4BvzXwvv6VPhtLlr4KiNEXJ3EgY2bREolgRQ=; b=X6wDXLhSpozc3I WALfg5IqBBJQs4cpQYXDBxIvSphaI/nTUNWyj1+sa2OU6vY62IltPMC1u2b86stnnGPU1suCJL2Rv +SqGxx1gVst8mHn2J+bFtW/p7PULWNRaD3MpzkDKM+1S8QpHjr+Aea40TaPSVfBWATokKepn/hxrC alPCDnpfA5u+qRoFnukL74cgVezNVxLPsd73/p3AhqHQvxJEp27RP21Bpp3s937vCCKZxfLkkargn tOcqLjzFNqox+nc7/ipGzYyCR3U6782cN/TZFRs6gs3d1Rehpu21Er+Ef/HCNNivysC/VawC6Np1W 5lYesx1TBUEvhIw4udbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7ZPl-00000004dqE-2qta; Thu, 16 May 2024 11:36:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7ZPi-00000004doP-27yk for linux-mtd@lists.infradead.org; Thu, 16 May 2024 11:36:48 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7ZPf-0007gw-Mt; Thu, 16 May 2024 13:36:43 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7ZPe-001hfo-Fw; Thu, 16 May 2024 13:36:42 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1s7ZPe-00Eqac-1I; Thu, 16 May 2024 13:36:42 +0200 Date: Thu, 16 May 2024 13:36:42 +0200 From: Sascha Hauer To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] mtd: nand: mxc_nand: implement exec_op Message-ID: References: <20240514-mtd-nand-mxc-nand-exec-op-v3-0-3e6f45fd3d82@pengutronix.de> <20240514-mtd-nand-mxc-nand-exec-op-v3-2-3e6f45fd3d82@pengutronix.de> <20240516103214.57a8ce33@xps-13> <20240516124405.2da1aa23@xps-13> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240516124405.2da1aa23@xps-13> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240516_043646_592724_9D347A95 X-CRM114-Status: GOOD ( 21.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, May 16, 2024 at 12:44:05PM +0200, Miquel Raynal wrote: > Hi Sascha, > = > s.hauer@pengutronix.de wrote on Thu, 16 May 2024 12:25:43 +0200: > = > > On Thu, May 16, 2024 at 10:32:14AM +0200, Miquel Raynal wrote: > > > Hi Sascha, > > > = > > > > +static const struct nand_op_parser mxcnd_op_parser =3D NAND_OP_PAR= SER( > > > > + NAND_OP_PARSER_PATTERN(mxcnd_do_exec_op, > > > > + NAND_OP_PARSER_PAT_CMD_ELEM(false), > > > > + NAND_OP_PARSER_PAT_ADDR_ELEM(true, 7), > > > > + NAND_OP_PARSER_PAT_CMD_ELEM(true), > > > > + NAND_OP_PARSER_PAT_WAITRDY_ELEM(true), > > > > + NAND_OP_PARSER_PAT_DATA_IN_ELEM(true, MAX_DATA_SIZE)), = > > > = > > > CMD, ADDR, CMD, DATA is the RNDOUT pattern. So it is now working fine= ? = > > = > > Yes, RNDOUT is working now. > = > Excellent! > = > > > Or did you forget to adapt the patterns to your use case? = > > = > > Although it looks like the patterns from the pl35x-nand-controller.c, > > there is one slight difference. The 'false' in the NAND_OP_PARSER_PAT_C= MD_ELEM > > above has the effect that a plain NAND_OP_PARSER_PAT_DATA_IN_ELEM is > > disallowed. > = > I'm not sure I follow, the above pattern means: a single command cycle > is supported, no? A single command cycle indeed is and shall be supported. The pl35x-nand-controller.c I copied this from has NAND_OP_PARSER_PAT_CMD_ELEM(true). With all elements being optional this also allows a single NAND_OP_PARSER_PAT_DATA_IN_ELEM() (supported_op.data_only_read becomes true). I can't support that, so I made the CMD mandatory. Sascha > = > Miqu=E8l > = -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/