of atmel_pmecc_destroy_user

From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: boris.brezillon@collabora.com
Cc: nicolas.ferre@microchip.com, miquel.raynal@bootlin.com,
	richard@nod.at, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: of atmel_pmecc_destroy_user
Date: Sun, 29 Sep 2024 17:05:01 +0000	[thread overview]
Message-ID: <ZvmIvRJCf6VhHvpo@gallifrey> (raw)

Hi Boris and co,
  One of my scripts noticed that 'atmel_pmecc_destroy_user'
isn't called anywhere; I was going to delete it, but hmm, I wonder
if it's actually a missing call and leaking (in the unlikely case
the device was ever removed).

It was added by your:
  commit f88fc122cc34c2545dec9562eaab121494e401ef
  Author: Boris Brezillon <bbrezillon@kernel.org>
  Date:   Thu Mar 16 09:02:40 2017 +0100

    mtd: nand: Cleanup/rework the atmel_nand driver

and I see the allocation in:
     user = kzalloc(size, GFP_KERNEL);
       in
     nand->pmecc = atmel_pmecc_create_user(nc->pmecc, &req);
       called in atmel_nand_pmecc_init
         from atmel_nand_ecc_init
           from atmel_hsmc_nand_ecc_init

But I don't see any freeing.

(I don't knowingly have hardware to test a fix, although I guess
there's probably one somewhere....)

Suggestions?

Thanks,

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/