From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f62ZI-0005gD-BX for linux-mtd@lists.infradead.org; Tue, 10 Apr 2018 23:20:53 +0000 Received: by mail-wm0-x234.google.com with SMTP id o23so23369788wmf.0 for ; Tue, 10 Apr 2018 16:20:41 -0700 (PDT) Subject: Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing. To: NeilBrown , Cyrille Pitchen Cc: David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: <874lkmw54j.fsf@notabene.neil.brown.name> <61e255fa-ece4-5566-d63a-730aaa25f18c@gmail.com> <87sh85uzu3.fsf@notabene.neil.brown.name> <87efjnvpjl.fsf@notabene.neil.brown.name> From: Marek Vasut Message-ID: Date: Wed, 11 Apr 2018 01:20:39 +0200 MIME-Version: 1.0 In-Reply-To: <87efjnvpjl.fsf@notabene.neil.brown.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 04/10/2018 03:05 AM, NeilBrown wrote: Skipping the previous discussion, I think there are actually two problems here. One is the reset and the other is braindead behavior of this flash. TLDR, you are right and this patch is needed (with minor tweak to make it winbond-only and possibly clean up the conditions a bit, maybe even pull it into separate function with some sensible name), sorry for the noise. I had to read up the datasheet and the discussion again, the behavior of the flash is horrid. [...] -- Best regards, Marek Vasut