From: Michael Walle <michael@walle.cc>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: linux-mtd@lists.infradead.org,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f
Date: Fri, 13 May 2022 19:21:52 +0200 [thread overview]
Message-ID: <a6515b6d3c790be8a66f30069a05df56@walle.cc> (raw)
In-Reply-To: <d59ec4e0-3bce-2b44-1fc5-54a26fe77c7f@nokia.com>
Hi,
Am 2022-05-13 18:09, schrieb Alexander Sverdlin:
>>> According to datasheet both Dual and Quad Read is supported. The read
>>> test
>>> shows x3.8 speed gain.
>>
>> Does it have SFDP? Try adding PARSE_SFDP instead of the
>> NO_SFDP_FLAGS.
>
> Some issues with its SFDP were known:
> https://patchwork.ozlabs.org/project/linux-mtd/patch/1492068234-9509-1-git-send-email-dev@kresin.me/
That doesn't seem to be the case for your flash. The quad and
dual flags you've added, will enable SFDP parsing anyway. So
instead of adding these flags, just adding PARSE_SFDP should
work, too. We still have to keep the SPI_NOR_4B_OPCODES.
>> Please post an SFDP dump of this flash [1].
Thanks.
>> xxd -p /sys/bus/spi/devices/spi0.0/sfdp
> 53464450060102ff00060110300000ffc2000104100100ff84000102c000
> 00ffffffffffffffffffffffffffffffffffe520fbffffffff0f44eb086b
> 083b04bbfeffffffffff00ffffff44eb0c200f5210d800ff8749b50082d2
> 04d24403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffff7f8fffff215cdcffffffffffffffffffffff
^^^^^^^^^^^^^^^^
That's the 4BAIT table.
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffff002050169df9c06485cbffffffffffff
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2022-05-13 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 9:47 [PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f Alexander A Sverdlin
2022-05-13 11:11 ` Michael Walle
2022-05-13 16:09 ` Alexander Sverdlin
2022-05-13 17:21 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6515b6d3c790be8a66f30069a05df56@walle.cc \
--to=michael@walle.cc \
--cc=alexander.sverdlin@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox