From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-db5eur01on0084.outbound.protection.outlook.com ([104.47.2.84] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f76hQ-0001lj-5U for linux-mtd@lists.infradead.org; Fri, 13 Apr 2018 21:57:41 +0000 From: Han Xu To: Stefan Agner , "boris.brezillon@free-electrons.com" CC: "marek.vasut@gmail.com" , "richard@nod.at" , "dwmw2@infradead.org" , "cyrille.pitchen@wedev4u.fr" , "max.oss.09@gmail.com" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/2] mtd: rawnand: gpmi: add support for specific ECC strength Date: Fri, 13 Apr 2018 21:57:24 +0000 Message-ID: References: <20180304200602.11475-1-stefan@agner.ch> In-Reply-To: <20180304200602.11475-1-stefan@agner.ch> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <8B69A6AE8D13EB4AB49159FE9EB9C566@eurprd04.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , DQoNCk9uIDAzLzA0LzIwMTggMDI6MDYgUE0sIFN0ZWZhbiBBZ25lciB3cm90ZToNCj4gQWRkIHN1 cHBvcnQgZm9yIHNwZWNpZmllZCBFQ0Mgc3RyZW5ndGgvc2l6ZSB1c2luZyBkZXZpY2UgdHJlZQ0K PiBwcm9wZXJ0aWVzIG5hbmQtZWNjLXN0cmVuZ3RoL25hbmQtZWNjLXN0ZXAtc2l6ZS4NCj4gDQo+ IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbiBBZ25lciA8c3RlZmFuQGFnbmVyLmNoPg0KPiAtLS0NCj4g ICBkcml2ZXJzL210ZC9uYW5kL2dwbWktbmFuZC9ncG1pLW5hbmQuYyB8IDMwICsrKysrKysrKysr KysrKysrKysrLS0tLS0tLS0tLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCsp LCAxMCBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL2dw bWktbmFuZC9ncG1pLW5hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvZ3BtaS1uYW5kL2dwbWktbmFu ZC5jDQo+IGluZGV4IDYxZmRkNzMzNDkyZi4uZDA0NzU0Mjg5YzAzIDEwMDY0NA0KPiAtLS0gYS9k cml2ZXJzL210ZC9uYW5kL2dwbWktbmFuZC9ncG1pLW5hbmQuYw0KPiArKysgYi9kcml2ZXJzL210 ZC9uYW5kL2dwbWktbmFuZC9ncG1pLW5hbmQuYw0KPiBAQCAtMTk4LDE3ICsxOTgsMTYgQEAgc3Rh dGljIGlubGluZSBib29sIGdwbWlfY2hlY2tfZWNjKHN0cnVjdCBncG1pX25hbmRfZGF0YSAqdGhp cykNCj4gICAgKg0KPiAgICAqIFdlIG1heSBoYXZlIGF2YWlsYWJsZSBvb2Igc3BhY2UgaW4gdGhp cyBjYXNlLg0KPiAgICAqLw0KPiAtc3RhdGljIGludCBzZXRfZ2VvbWV0cnlfYnlfZWNjX2luZm8o c3RydWN0IGdwbWlfbmFuZF9kYXRhICp0aGlzKQ0KPiArc3RhdGljIGludCBzZXRfZ2VvbWV0cnlf YnlfZWNjX2luZm8oc3RydWN0IGdwbWlfbmFuZF9kYXRhICp0aGlzLA0KPiArCQkJCSAgICB1bnNp Z25lZCBpbnQgZWNjX3N0cmVuZ3RoLA0KPiArCQkJCSAgICB1bnNpZ25lZCBpbnQgZWNjX3N0ZXAp DQo+ICAgew0KPiAgIAlzdHJ1Y3QgYmNoX2dlb21ldHJ5ICpnZW8gPSAmdGhpcy0+YmNoX2dlb21l dHJ5Ow0KPiAgIAlzdHJ1Y3QgbmFuZF9jaGlwICpjaGlwID0gJnRoaXMtPm5hbmQ7DQo+ICAgCXN0 cnVjdCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQoY2hpcCk7DQo+ICAgCXVuc2lnbmVkIGlu dCBibG9ja19tYXJrX2JpdF9vZmZzZXQ7DQo+ICAgDQo+IC0JaWYgKCEoY2hpcC0+ZWNjX3N0cmVu Z3RoX2RzID4gMCAmJiBjaGlwLT5lY2Nfc3RlcF9kcyA+IDApKQ0KPiAtCQlyZXR1cm4gLUVJTlZB TDsNCj4gLQ0KPiAtCXN3aXRjaCAoY2hpcC0+ZWNjX3N0ZXBfZHMpIHsNCj4gKwlzd2l0Y2ggKGVj Y19zdGVwKSB7DQo+ICAgCWNhc2UgU1pfNTEyOg0KPiAgIAkJZ2VvLT5nZl9sZW4gPSAxMzsNCj4g ICAJCWJyZWFrOw0KPiBAQCAtMjIxLDggKzIyMCw4IEBAIHN0YXRpYyBpbnQgc2V0X2dlb21ldHJ5 X2J5X2VjY19pbmZvKHN0cnVjdCBncG1pX25hbmRfZGF0YSAqdGhpcykNCj4gICAJCQljaGlwLT5l Y2Nfc3RyZW5ndGhfZHMsIGNoaXAtPmVjY19zdGVwX2RzKTsNCj4gICAJCXJldHVybiAtRUlOVkFM Ow0KPiAgIAl9DQo+IC0JZ2VvLT5lY2NfY2h1bmtfc2l6ZSA9IGNoaXAtPmVjY19zdGVwX2RzOw0K PiAtCWdlby0+ZWNjX3N0cmVuZ3RoID0gcm91bmRfdXAoY2hpcC0+ZWNjX3N0cmVuZ3RoX2RzLCAy KTsNCj4gKwlnZW8tPmVjY19jaHVua19zaXplID0gZWNjX3N0ZXA7DQo+ICsJZ2VvLT5lY2Nfc3Ry ZW5ndGggPSByb3VuZF91cChlY2Nfc3RyZW5ndGgsIDIpOw0KPiAgIAlpZiAoIWdwbWlfY2hlY2tf ZWNjKHRoaXMpKQ0KPiAgIAkJcmV0dXJuIC1FSU5WQUw7DQo+ICAgDQo+IEBAIC0yMzAsNyArMjI5 LDcgQEAgc3RhdGljIGludCBzZXRfZ2VvbWV0cnlfYnlfZWNjX2luZm8oc3RydWN0IGdwbWlfbmFu ZF9kYXRhICp0aGlzKQ0KPiAgIAlpZiAoZ2VvLT5lY2NfY2h1bmtfc2l6ZSA8IG10ZC0+b29ic2l6 ZSkgew0KPiAgIAkJZGV2X2Vycih0aGlzLT5kZXYsDQo+ICAgCQkJInVuc3VwcG9ydGVkIG5hbmQg Y2hpcC4gZWNjIHNpemU6ICVkLCBvb2Igc2l6ZSA6ICVkXG4iLA0KPiAtCQkJY2hpcC0+ZWNjX3N0 ZXBfZHMsIG10ZC0+b29ic2l6ZSk7DQo+ICsJCQllY2Nfc3RlcCwgbXRkLT5vb2JzaXplKTsNCj4g ICAJCXJldHVybiAtRUlOVkFMOw0KPiAgIAl9DQo+ICAgDQo+IEBAIC00MjMsOSArNDIyLDIwIEBA IHN0YXRpYyBpbnQgbGVnYWN5X3NldF9nZW9tZXRyeShzdHJ1Y3QgZ3BtaV9uYW5kX2RhdGEgKnRo aXMpDQo+ICAgDQo+ICAgaW50IGNvbW1vbl9uZmNfc2V0X2dlb21ldHJ5KHN0cnVjdCBncG1pX25h bmRfZGF0YSAqdGhpcykNCj4gICB7DQo+ICsJc3RydWN0IG5hbmRfY2hpcCAqY2hpcCA9ICZ0aGlz LT5uYW5kOw0KPiArDQo+ICsJaWYgKGNoaXAtPmVjYy5zdHJlbmd0aCA+IDAgJiYgY2hpcC0+ZWNj LnNpemUgPiAwKQ0KPiArCQlyZXR1cm4gc2V0X2dlb21ldHJ5X2J5X2VjY19pbmZvKHRoaXMsIGNo aXAtPmVjYy5zdHJlbmd0aCwNCj4gKwkJCQkJCWNoaXAtPmVjYy5zaXplKTsNCj4gKw0KPiAgIAlp ZiAoKG9mX3Byb3BlcnR5X3JlYWRfYm9vbCh0aGlzLT5kZXYtPm9mX25vZGUsICJmc2wsdXNlLW1p bmltdW0tZWNjIikpDQo+IC0JCQkJfHwgbGVnYWN5X3NldF9nZW9tZXRyeSh0aGlzKSkNCj4gLQkJ cmV0dXJuIHNldF9nZW9tZXRyeV9ieV9lY2NfaW5mbyh0aGlzKTsNCj4gKwkJCQl8fCBsZWdhY3lf c2V0X2dlb21ldHJ5KHRoaXMpKSB7DQo+ICsJCWlmICghKGNoaXAtPmVjY19zdHJlbmd0aF9kcyA+ IDAgJiYgY2hpcC0+ZWNjX3N0ZXBfZHMgPiAwKSkNCj4gKwkJCXJldHVybiAtRUlOVkFMOw0KPiAr DQo+ICsJCXJldHVybiBzZXRfZ2VvbWV0cnlfYnlfZWNjX2luZm8odGhpcywgY2hpcC0+ZWNjX3N0 cmVuZ3RoX2RzLA0KPiArCQkJCQkJY2hpcC0+ZWNjX3N0ZXBfZHMpOw0KPiArCX0NCj4gICANCj4g ICAJcmV0dXJuIDA7DQo+ICAgfQ0KPiANCg0KQWNrZWQtYnk6IEhhbiBYdSA8aGFuLnh1QG54cC5j b20+