Re: [PATCH v2 12/35] mtd: spi-nor: xilinx: Use manufacturer late_init() to set setup method

Pratyush Yadav
2021-08-16T19:20:14Z

On 27/07/21 07:51AM, Tudor Ambarus wrote:
> post_sfdp was misleading in this case, as SFDP is not supported by
> xilinx. Plus, there's no fixup here, just setting the correct
> setup method, as required by xilinx parts.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

> ---
> drivers/mtd/spi-nor/xilinx.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/xilinx.c b/drivers/mtd/spi-nor/xilinx.c
> index 1138bdbf4199..a573c3cde414 100644
> --- a/drivers/mtd/spi-nor/xilinx.c
> +++ b/drivers/mtd/spi-nor/xilinx.c
> @@ -77,18 +77,14 @@ static int xilinx_nor_setup(struct spi_nor *nor,
> return 0;
> }
>
> -static void xilinx_post_sfdp_fixups(struct spi_nor *nor)
> +static void xilinx_late_init(struct spi_nor *nor)
> {
> nor->params->setup = xilinx_nor_setup;
> }
>
> -static const struct spi_nor_fixups xilinx_fixups = {
> - .post_sfdp = xilinx_post_sfdp_fixups,
> -};
> -
> const struct spi_nor_manufacturer spi_nor_xilinx = {
> .name = "xilinx",
> .parts = xilinx_parts,
> .nparts = ARRAY_SIZE(xilinx_parts),
> - .fixups = &xilinx_fixups,
> + .late_init = xilinx_late_init,
> };
> --
> 2.25.1
>

--
Regards,
Pratyush Yadav
Texas Instruments Inc.