Re: [PATCH v2 35/35] docs: mtd: spi-nor: Add details about how to propose a new flash addition

Pratyush Yadav
2021-08-24T18:00:08Z

On 27/07/21 09:22AM, Michael Walle wrote:
> Am 2021-07-27 06:52, schrieb Tudor Ambarus:
> > Add some guideliness on how to propose a new flash addition.
> >
> > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> > ---
> > Documentation/driver-api/mtd/spi-nor.rst | 65 ++++++++++++++++++++++++
> > 1 file changed, 65 insertions(+)
> >
> > diff --git a/Documentation/driver-api/mtd/spi-nor.rst
> > b/Documentation/driver-api/mtd/spi-nor.rst
> > index 4a3adca417fd..ffb8d97a2766 100644
> > --- a/Documentation/driver-api/mtd/spi-nor.rst
> > +++ b/Documentation/driver-api/mtd/spi-nor.rst
> [..]
> > +Every new flash addition that define the SFDP tables, should hexdump
> > its SFDP
> > +tables in the patch's comment section below the --- line, so that we
> > can
> > +reference it in case of ID collisions.
>
> Nice, but could you add some guidelines how to do it? That is the exact
> commands, maybe with a notice one should use these whenever possible. I
> want to prevent having all sorts of variations of the output and I want
> to be able to reverse the operation and verify it.
>
> # xxd -p /path/to/sfdp
> # md5sum /path/to/sfdp
> # cat /path/to/jedec_id
> # cat /path/to/partname
> # cat /path/to/manufacturer

It would be nice if we could have checkpatch.pl check for these. But I
don't know how difficult that would be to add.

--
Regards,
Pratyush Yadav
Texas Instruments Inc.