From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64352C3ABD8 for ; Fri, 16 May 2025 22:19:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XIlwcMnBjsjPsoWi4xTh9BomlsQVFUgARKhp+QgSq4s=; b=Skk6TXBcumeFAZ wJMRAuwdEmZjZNkSBxUyh5YPQD1dzT5kvD6A2CqlI5IBZ1u+ZXIgm82GP0K64ZLzxU6rbz6lNRlS6 jLLL4UhYLaAu+CZiF+TBxaQr1W+0W6FgMqM7ZV/IOP0UfupovQYxBcdk5FiLtdCPNqbgSqPP0ckQG jD0eBJHYjY+YACSzwOV7AXCNc9Vkp+0zsXxDHr708erm0D2vygckqFts0ns32E7Z3+m2i45GrgjYA nib/QhqX+nN75kaDPDmyIAd1zOUrFvijYRW250KEwcQJm5d5ERCcJRkFzulXR/JzP6nZHlZlKtTCh PdlSeBCD8fcDOIXUTIHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uG3Ou-00000004jsf-3B8T; Fri, 16 May 2025 22:19:32 +0000 Received: from mgamail.intel.com ([198.175.65.9]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uG3Os-00000004jsA-3CNZ for linux-mtd@lists.infradead.org; Fri, 16 May 2025 22:19:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747433971; x=1778969971; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pNQgrf3kHx9tBSk5s9dabdfvWxeLz9IouCzZLXtswm8=; b=U8qMxHzFhRVn+Ao8ylNAwLBUsqyOwxJq33dfzHAPT7zl4aVFDSI6WDXd UDZaThxKPApmWL8hNPT5dmV51C0rUFWM7cz1ASxUERE5+OB6I6Udc6SCk OdK7CiM5Hda4nKU8F7v1wVxyvAT5eNMghO69zwdb5YzGcXjvpRkM56cSN 5rnKSZI/s/sNKdrD07u+JyfTwVl3D9Npfxe60Q/0fZf208/8md0YNB3nK FBwBTUTAFrdSl4qCpE1hCTgsmtSj0cAeX9j5/PdJQfDkWl9pD3QXJu+Vw 6e/gDI07hme6cy2Vik7Z++vELx90Y+Lhu+vJoS9W2kLcWHjhMimTGMbB5 w==; X-CSE-ConnectionGUID: ZAHKvl0HTwizqW/cNytMag== X-CSE-MsgGUID: vQ/YNEhMRrm7/YqraT0dUg== X-IronPort-AV: E=McAfee;i="6700,10204,11435"; a="71922652" X-IronPort-AV: E=Sophos;i="6.15,295,1739865600"; d="scan'208";a="71922652" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2025 15:19:28 -0700 X-CSE-ConnectionGUID: zhBWBYrtT3y3PomN/O1Ofw== X-CSE-MsgGUID: Y0x76TZKR5mErtlBiwu4Ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,295,1739865600"; d="scan'208";a="175946731" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2025 15:19:23 -0700 Date: Sat, 17 May 2025 01:19:19 +0300 From: Raag Jadav To: Alexander Usyskin Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , Karthik Poosa , Reuven Abliyev , Oren Weil , linux-mtd@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomas Winkler Subject: Re: [PATCH v10 01/10] mtd: add driver for intel graphics non-volatile memory device Message-ID: References: <20250515133345.2805031-1-alexander.usyskin@intel.com> <20250515133345.2805031-2-alexander.usyskin@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250515133345.2805031-2-alexander.usyskin@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250516_151930_888246_2C825AAB X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, May 15, 2025 at 04:33:36PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > non-volatile memory device. A few nits below but we're good to go. Reviewed-by: Raag Jadav ... > +static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev, > + const struct auxiliary_device_id *aux_dev_id) > +{ > + struct intel_dg_nvm_dev *invm = auxiliary_dev_to_intel_dg_nvm_dev(aux_dev); > + struct device *device; > + struct intel_dg_nvm *nvm; > + unsigned int nregions; > + unsigned int i, n; > + int ret; Reverse xmas order (and same for all other patches for consistency). ... > diff --git a/include/linux/intel_dg_nvm_aux.h b/include/linux/intel_dg_nvm_aux.h > new file mode 100644 > index 000000000000..53193fda55eb > --- /dev/null > +++ b/include/linux/intel_dg_nvm_aux.h > @@ -0,0 +1,29 @@ > +/* SPDX-License-Identifier: MIT */ > +/* > + * Copyright(c) 2019-2025, Intel Corporation. All rights reserved. > + */ > + > +#ifndef __INTEL_DG_NVM_AUX_H__ > +#define __INTEL_DG_NVM_AUX_H__ > + > +#include > +#include > +#include Missing ioport.h > +#define INTEL_DG_NVM_REGIONS 13 > + > +struct intel_dg_nvm_region { > + const char *name; > +}; > + > +struct intel_dg_nvm_dev { > + struct auxiliary_device aux_dev; > + bool writable_override; > + struct resource bar; > + const struct intel_dg_nvm_region *regions; > +}; > + > +#define auxiliary_dev_to_intel_dg_nvm_dev(auxiliary_dev) \ > + container_of(auxiliary_dev, struct intel_dg_nvm_dev, aux_dev) > + > +#endif /* __INTEL_DG_NVM_AUX_H__ */ > -- > 2.43.0 > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/