From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Usyskin <alexander.usyskin@intel.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Reuven Abliyev <reuven.abliyev@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] mtd: intel-dg: wake card on operations
Date: Mon, 20 Oct 2025 13:10:06 +0300 [thread overview]
Message-ID: <aPYKfhTDF5kXulz9@ashevche-desk.local> (raw)
In-Reply-To: <aPYKRvCenwnrFXcb@ashevche-desk.local>
On Mon, Oct 20, 2025 at 01:09:10PM +0300, Andy Shevchenko wrote:
> On Sun, Oct 19, 2025 at 06:01:45PM +0300, Alexander Usyskin wrote:
> > Enable runtime PM in mtd driver to notify parent graphics driver
> > that whole card should be kept awake while nvm operations are
> > performed through this driver.
Ah, and perhaps a bit elaboration why graphics card needs that?
...
> > + pm_runtime_mark_last_busy(nvm->dev);
> > + pm_runtime_put_autosuspend(nvm->dev);
>
> Please, drop the second (duplicate) call.
...
> > + devm_pm_runtime_enable(device);
>
> Please, justify why this code is good without error checking. Before doing that
> think for a moment for the cases when devm_*() might be developed in the future
> and return something interesting (if not yet).
...
> > err:
> > + pm_runtime_put(device);
> > +err_norpm:
> > kref_put(&nvm->refcnt, intel_dg_nvm_release);
> > return ret;
>
> Mixing devm with non-devm usually lead to hard to catch bugs in the error paths
> / remove stages with ordering of cleaning resources up.
--
With Best Regards,
Andy Shevchenko
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-10-20 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 15:01 [PATCH] mtd: intel-dg: wake card on operations Alexander Usyskin
2025-10-20 10:09 ` Andy Shevchenko
2025-10-20 10:10 ` Andy Shevchenko [this message]
2025-10-21 12:51 ` Usyskin, Alexander
2025-10-21 14:39 ` Andy Shevchenko
2025-10-21 15:03 ` Lucas De Marchi
2025-10-23 10:53 ` Usyskin, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPYKfhTDF5kXulz9@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lucas.demarchi@intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=reuven.abliyev@intel.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox