From: Lukas Wunner <lukas@wunner.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame
Date: Wed, 8 Apr 2026 08:35:52 +0200 [thread overview]
Message-ID: <adX3SHYgazijahbG@wunner.de> (raw)
In-Reply-To: <20260204012630.2211832-1-andriy.shevchenko@linux.intel.com>
On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote:
> Compiler is not happy about used stack frame:
>
> drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer':
> drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
>
> Fix this by factoring out do_write_buffer_locked().
FWIW, the issue only occurs with CONFIG_KASAN_STACK=y, so an alternative
to refactoring the function is to disable KASAN for this particular file:
diff --git a/drivers/mtd/chips/Makefile b/drivers/mtd/chips/Makefile
index 1f4e84f1cd88..7110eb97bd25 100644
--- a/drivers/mtd/chips/Makefile
+++ b/drivers/mtd/chips/Makefile
@@ -14,3 +14,8 @@ obj-$(CONFIG_MTD_JEDECPROBE) += jedec_probe.o
obj-$(CONFIG_MTD_RAM) += map_ram.o
obj-$(CONFIG_MTD_ROM) += map_rom.o
obj-$(CONFIG_MTD_ABSENT) += map_absent.o
+
+# Avoid exceeding stack frame in do_write_buffer()
+ifeq ($(ARCH),arm)
+KASAN_SANITIZE_cfi_cmdset_0001.o := n
+endif
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-04-08 6:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 1:25 [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame Andy Shevchenko
2026-02-04 21:12 ` Andy Shevchenko
2026-02-05 8:51 ` Miquel Raynal
2026-02-05 15:57 ` Andy Shevchenko
2026-02-05 17:34 ` Miquel Raynal
2026-02-06 5:56 ` Vignesh Raghavendra
2026-02-06 7:44 ` Andy Shevchenko
2026-04-08 6:35 ` Lukas Wunner [this message]
2026-04-08 11:27 ` Andy Shevchenko
2026-04-08 13:40 ` Lukas Wunner
2026-04-08 14:33 ` Andy Shevchenko
2026-04-08 21:17 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2026-01-24 13:35 Andy Shevchenko
2026-01-24 22:41 ` kernel test robot
2026-02-10 10:05 ` Vignesh Raghavendra
2026-02-10 14:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adX3SHYgazijahbG@wunner.de \
--to=lukas@wunner.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox