[PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

[PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

[Marek Vasut]

Add IDs for Winbond W77Q51NW, 512M-bit Secure Serial Flash Memory
with Post-Quantum Cryptography, Dual/Quad SPI, QPI and DTR . The
flash part is similar to W25Q512NWM .

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Michael Walle <mwalle@kernel.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Pratyush Yadav <pratyush@kernel.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-mtd@lists.infradead.org
---
 drivers/mtd/spi-nor/winbond.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 63a93c9eb917..dcb6c9ec862a 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -343,6 +343,10 @@ static const struct flash_info winbond_nor_parts[] = {
 		.id = SNOR_ID(0xef, 0x80, 0x20),
 		.name = "w25q512nwm",
 		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
+	}, {
+		.id = SNOR_ID(0xef, 0x8a, 0x1a),
+		.name = "w77q51nw",
+		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
 	},
 };
 
-- 
2.47.2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

[Tudor Ambarus]

hiya, Marek,

On 7/20/25 8:55 PM, Marek Vasut wrote:
> Add IDs for Winbond W77Q51NW, 512M-bit Secure Serial Flash Memory
> with Post-Quantum Cryptography, Dual/Quad SPI, QPI and DTR . The
> flash part is similar to W25Q512NWM .
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Michael Walle <mwalle@kernel.org>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Pratyush Yadav <pratyush@kernel.org>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-mtd@lists.infradead.org
> ---
>  drivers/mtd/spi-nor/winbond.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 63a93c9eb917..dcb6c9ec862a 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -343,6 +343,10 @@ static const struct flash_info winbond_nor_parts[] = {
>  		.id = SNOR_ID(0xef, 0x80, 0x20),
>  		.name = "w25q512nwm",
>  		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
> +	}, {
> +		.id = SNOR_ID(0xef, 0x8a, 0x1a),
> +		.name = "w77q51nw",

we concluded that the name is not relevant, as there can be flashes
that update their name or worse, entirely different flashes that use
the same flash ID. So please add the name as a comment, above the flash
definition. See recent flash additions.

Also, we introduced some minimum testing requirements, so that we make
sure that the flash was tested at the time of submission and also to
save the dtb database in case other flashes reuse the flash ID, or
different flavors appear, etc. Please do the tests described at:
https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements

Cheers,
ta


> +		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
>  	},
>  };
>  


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

[Marek Vasut]

On 7/21/25 11:28 AM, Tudor Ambarus wrote:

Hi,

>> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
>> index 63a93c9eb917..dcb6c9ec862a 100644
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -343,6 +343,10 @@ static const struct flash_info winbond_nor_parts[] = {
>>   		.id = SNOR_ID(0xef, 0x80, 0x20),
>>   		.name = "w25q512nwm",
>>   		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
>> +	}, {
>> +		.id = SNOR_ID(0xef, 0x8a, 0x1a),
>> +		.name = "w77q51nw",
> 
> we concluded that the name is not relevant, as there can be flashes
> that update their name or worse, entirely different flashes that use
> the same flash ID. So please add the name as a comment, above the flash
> definition. See recent flash additions.
> 
> Also, we introduced some minimum testing requirements, so that we make
> sure that the flash was tested at the time of submission and also to
> save the dtb database in case other flashes reuse the flash ID, or
> different flavors appear, etc. Please do the tests described at:
> https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements
Should all be part of V2 I just posted, thanks .

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/