From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1emjsv-0004us-37 for linux-mtd@lists.infradead.org; Fri, 16 Feb 2018 17:33:23 +0000 Date: Fri, 16 Feb 2018 18:23:24 +0100 (CET) From: Julia Lawall To: Ezequiel Garcia cc: Shreeya Patel , Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , outreachy-kernel , linux-mtd@lists.infradead.org Subject: Re: [Outreachy kernel] Re: [PATCH NAND 0/5] Replace printk statements with pr_*macros In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1437051580-1518801804=:4340" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --8323329-1437051580-1518801804=:4340 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 16 Feb 2018, Ezequiel Garcia wrote: > Hi Shreeya, > > Thanks for the contribution. > > On 16 February 2018 at 13:50, Shreeya Patel > wrote: > > This patchset removes all the log levels i.e. KERN_WARN, > > KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk > > statements and replaces the printk statements with appropriate > > pr_*macros. > > According to the kernel coding style, pr_*macro is the preferred > > way to print the message. > > > > So, two things to begin with. > > First of all, despite this contribution being part of outreachy, > I believe you can include mailing lists in your case. > > In other words, don't use the "nol" option in get_maintainer > script and Cc the MTD mailing list: linux-mtd at lists.infradead.org. Shouldn't the dev_* functions also be usable? julia > > > > > Shreeya Patel (5): > > mtd/nand: Replace printk with pr_warn > > mtd/nand: Replace printk with pr_notice > > mtd/nand: Replace printk with pr_err > > mtd/nand: Replace printk with pr_info > > mtd/nand: Replace printk with pr_debug > > > > This is a non-usual split. We usually split patches per-driver, > instead of grouping all the pr_{} of a given type together. > > Can you re-do the series? Grouping the changes per-driver, > i.e. all the pr_{} changes in cafe_nand.c together, and so on. > > > drivers/mtd/nand/ams-delta.c | 4 +-- > > drivers/mtd/nand/cafe_nand.c | 4 +-- > > drivers/mtd/nand/cs553x_nand.c | 8 ++--- > > drivers/mtd/nand/diskonchip.c | 76 +++++++++++++++++++++------------------- > > drivers/mtd/nand/fsl_elbc_nand.c | 4 +-- > > drivers/mtd/nand/fsl_ifc_nand.c | 2 +- > > drivers/mtd/nand/mxc_nand.c | 2 +- > > drivers/mtd/nand/nand_bch.c | 12 +++---- > > drivers/mtd/nand/nandsim.c | 10 +++--- > > drivers/mtd/nand/r852.c | 2 +- > > drivers/mtd/nand/r852.h | 6 ++-- > > drivers/mtd/nand/sh_flctl.c | 2 +- > > drivers/mtd/nand/sm_common.c | 5 ++- > > 13 files changed, 70 insertions(+), 67 deletions(-) > > > > -- > > 2.7.4 > > > > > > -- > Ezequiel García, VanguardiaSur > www.vanguardiasur.com.ar > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAAEAJfAg_hei2PF37_oX2tf%2BMv43ye-nEOt%2BKRVFerp1Jfzn2Q%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > --8323329-1437051580-1518801804=:4340--