public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Adrian Hunter <ext-adrian.hunter@nokia.com>
Cc: "Bityutskiy Artem \\\(Nokia-M/Helsinki\\\)"
	<Artem.Bityutskiy@nokia.com>,
	dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: JFFS2 deadlock in erase callback
Date: Wed, 10 Oct 2007 21:51:22 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.0.9999.0710102144510.3147@localhost.localdomain> (raw)
In-Reply-To: <4709DF8E.1030707@nokia.com>

On Mon, 8 Oct 2007, Adrian Hunter wrote:
>         [MTD] [NAND] Avoid deadlock in erase callback; release chip lock first.
>     
>         When the erase callback performs some other action on the flash, it's
>         highly likely to deadlock unless we actually release the chip lock
>         before calling it.
>     
>         Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> 
> Can you confirm, that adding the "Avoid deadlock..." patch is better
> than reverting "Reduce time..." patch.

Yep, it's safe and definitely better.

I remember vaguely that we planned/discussed to move the release
before the callback some time ago, but the patch never made it into
mainline.
 
	tglx

      reply	other threads:[~2007-10-10 19:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08  7:43 JFFS2 deadlock in erase callback Adrian Hunter
2007-10-10 19:51 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.9999.0710102144510.3147@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=dwmw2@infradead.org \
    --cc=ext-adrian.hunter@nokia.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox