From: Thomas Gleixner <tglx@linutronix.de>
To: "Jörn Engel" <joern@logfs.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Matt Reimer <mreimer@vpop.net>,
linux-mtd@lists.infradead.org, mattjreimer@gmail.com
Subject: Re: [PATCH] BUG() when passing illegal parameters to decode_rs8() or decode_rs16()
Date: Sun, 21 Oct 2007 10:04:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.0.9999.0710210958220.22770@localhost.localdomain> (raw)
In-Reply-To: <20071020111126.GE32465@lazybastard.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 578 bytes --]
On Sat, 20 Oct 2007, Jörn Engel wrote:
> Returning -ERANGE should never happen.
>
> --- linux-2.6.22cow/lib/reed_solomon/decode_rs.c~rs_ERANGE 2006-10-13 15:58:51.000000000 +0200
> +++ linux-2.6.22cow/lib/reed_solomon/decode_rs.c 2007-10-20 13:07:57.000000000 +0200
> @@ -39,8 +39,7 @@
>
> /* Check length parameter for validity */
> pad = nn - nroots - len;
> - if (pad < 0 || pad >= nn)
> - return -ERANGE;
> + BUG_ON(pad < 0 || pad >= nn);
No. This is not a critical error. You escalate a situation where the
kernel can still survive to a fatal error.
tglx
next prev parent reply other threads:[~2007-10-21 8:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 21:33 [PATCH] MTD: treat any negative return value from correct() as an error mattjreimer
2007-10-20 10:42 ` Jörn Engel
2007-10-20 11:11 ` [PATCH] BUG() when passing illegal parameters to decode_rs8() or decode_rs16() Jörn Engel
2007-10-20 11:13 ` [PATCH] Replace -1 with -EBADMSG in nand error correction code Jörn Engel
2007-10-21 8:08 ` Thomas Gleixner
2007-10-21 8:42 ` Jörn Engel
2007-10-21 8:04 ` Thomas Gleixner [this message]
2007-10-21 8:06 ` [PATCH] BUG() when passing illegal parameters to decode_rs8() or decode_rs16() Thomas Gleixner
2007-10-21 8:48 ` Jörn Engel
2007-10-20 16:37 ` [PATCH] MTD: treat any negative return value from correct() as an error Matt Reimer
2007-10-20 17:40 ` Jörn Engel
2007-10-20 17:59 ` Matthew Reimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0710210958220.22770@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=dwmw2@infradead.org \
--cc=joern@logfs.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mattjreimer@gmail.com \
--cc=mreimer@vpop.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox