From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from www.tglx.de ([62.245.132.106]) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1Lqxuz-0001Oo-7O for linux-mtd@lists.infradead.org; Mon, 06 Apr 2009 23:08:11 +0000 Date: Tue, 7 Apr 2009 01:07:44 +0200 (CEST) From: Thomas Gleixner To: Sneha Narnakaje Subject: Re: [PATCH] MTD-NAND: Changes to read_page APIs to support NAND_ECC_HW_SYNDROME mode on TI DaVinci DM355 In-Reply-To: <1238601784-9563-1-git-send-email-nsnehaprabha@ti.com> Message-ID: References: <1238601784-9563-1-git-send-email-nsnehaprabha@ti.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: davinci-linux-open-source@linux.davincidsp.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sandeep Paulraj List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sneha, On Wed, 1 Apr 2009, nsnehaprabha@ti.com wrote: Would you please care to CC the still caring but admittedly lazy and distracted maintainer on such patches ? > From: Sneha Narnakaje > > The NAND controller on TI DaVinci DM355 supports NAND devices with large page size (2K and 4K), but the HW ECC is handled for every 512byte read/write chunks. The current HW_SYNDROME read_page/write_page APIs in the NAND core (nand_base) use the "infix OOB" scheme. The core APIs overwrite NAND manufacturer's bad block meta data, thus complicating the jobs of non-Linux NAND programmers (end equipment manufacturering). These APIs also imply ECC protection for the prepad bytes, causing nand raw_write operations to fail. Please use proper line breaks. 523 characters do not fit into a terminal. Thanks, tglx