* [PATCH] MTD: Correct misspelled Kconfig var CONFIG_MTD_DATAFLASH_VERIFY_WRITE
@ 2009-09-11 9:42 Robert P. J. Day
0 siblings, 0 replies; 5+ messages in thread
From: Robert P. J. Day @ 2009-09-11 9:42 UTC (permalink / raw)
To: MTD mailing list
Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE ->
CONFIG_MTD_DATAFLASH_VERIFY_WRITE to match the Kconfig variable in
drivers/mtd/devices/Kconfig.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index 43976aa..70a7369 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -401,7 +401,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
(void) dataflash_waitready(priv->spi);
-#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
+#ifdef CONFIG_MTD_DATAFLASH_WRITE_VERIFY
/* (3) Compare to Buffer1 */
addr = pageaddr << priv->page_offset;
@@ -430,7 +430,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
} else
status = 0;
-#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
+#endif /* CONFIG_MTD_DATAFLASH_WRITE_VERIFY */
remaining = remaining - writelen;
pageaddr++;
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] MTD: Correct misspelled Kconfig var CONFIG_MTD_DATAFLASH_VERIFY_WRITE
@ 2009-09-11 9:44 Robert P. J. Day
2009-09-11 18:50 ` Peter Korsgaard
2009-09-14 15:07 ` Artem Bityutskiy
0 siblings, 2 replies; 5+ messages in thread
From: Robert P. J. Day @ 2009-09-11 9:44 UTC (permalink / raw)
To: MTD mailing list
Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE ->
CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in
drivers/mtd/devices/Kconfig.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
whoops, sorry, previous commit msg didn't show the actual
correction, this one does.
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index 43976aa..70a7369 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -401,7 +401,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
(void) dataflash_waitready(priv->spi);
-#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
+#ifdef CONFIG_MTD_DATAFLASH_WRITE_VERIFY
/* (3) Compare to Buffer1 */
addr = pageaddr << priv->page_offset;
@@ -430,7 +430,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
} else
status = 0;
-#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
+#endif /* CONFIG_MTD_DATAFLASH_WRITE_VERIFY */
remaining = remaining - writelen;
pageaddr++;
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MTD: Correct misspelled Kconfig var CONFIG_MTD_DATAFLASH_VERIFY_WRITE
2009-09-11 9:44 Robert P. J. Day
@ 2009-09-11 18:50 ` Peter Korsgaard
2009-09-14 15:07 ` Artem Bityutskiy
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2009-09-11 18:50 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: MTD mailing list
>>>>> "Robert" == Robert P J Day <rpjday@crashcourse.ca> writes:
Robert> Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE ->
Robert> CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in
Robert> drivers/mtd/devices/Kconfig.
Robert> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MTD: Correct misspelled Kconfig var CONFIG_MTD_DATAFLASH_VERIFY_WRITE
2009-09-11 9:44 Robert P. J. Day
2009-09-11 18:50 ` Peter Korsgaard
@ 2009-09-14 15:07 ` Artem Bityutskiy
2009-09-14 17:07 ` Robert P. J. Day
1 sibling, 1 reply; 5+ messages in thread
From: Artem Bityutskiy @ 2009-09-14 15:07 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: MTD mailing list
On Fri, 2009-09-11 at 05:44 -0400, Robert P. J. Day wrote:
> Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE ->
> CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in
> drivers/mtd/devices/Kconfig.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Actually, a patch you sent earlier is already in the mtd-2.6.git tree:
http://git.infradead.org/mtd-2.6.git/commit/05dd180709fca14fbae617c0dab1bed56be334fc
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MTD: Correct misspelled Kconfig var CONFIG_MTD_DATAFLASH_VERIFY_WRITE
2009-09-14 15:07 ` Artem Bityutskiy
@ 2009-09-14 17:07 ` Robert P. J. Day
0 siblings, 0 replies; 5+ messages in thread
From: Robert P. J. Day @ 2009-09-14 17:07 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: MTD mailing list
On Mon, 14 Sep 2009, Artem Bityutskiy wrote:
> On Fri, 2009-09-11 at 05:44 -0400, Robert P. J. Day wrote:
> > Make the source file correction CONFIG_MTD_DATAFLASH_VERIFY_WRITE ->
> > CONFIG_MTD_DATAFLASH_WRITE_VERIFY to match the Kconfig variable in
> > drivers/mtd/devices/Kconfig.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> Actually, a patch you sent earlier is already in the mtd-2.6.git tree:
> http://git.infradead.org/mtd-2.6.git/commit/05dd180709fca14fbae617c0dab1bed56be334fc
i submitted a different one based on the recommendation of what
should be changed for those two bits of text to match up. either one
of those two patches will work just fine, they just resolve the issue
in opposite ways. whatever people on this list prefer is fine with
me.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-14 17:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-11 9:42 [PATCH] MTD: Correct misspelled Kconfig var CONFIG_MTD_DATAFLASH_VERIFY_WRITE Robert P. J. Day
-- strict thread matches above, loose matches on Subject: below --
2009-09-11 9:44 Robert P. J. Day
2009-09-11 18:50 ` Peter Korsgaard
2009-09-14 15:07 ` Artem Bityutskiy
2009-09-14 17:07 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).