* simplifying the linux MTD Kconfig/Makefile structure
@ 2010-03-30 12:29 Robert P. J. Day
2010-04-23 12:05 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2010-03-30 12:29 UTC (permalink / raw)
To: MTD mailing list
it seems like the various Kconfigs and Makefiles related to MTD
could be tightened up a bit. for instance, in drivers/mtd/Makefile:
obj-$(CONFIG_MTD_UBI) += ubi/
but given that selection, it's kind of redundant to then have
drivers/mtd/ubi/Makefile start with:
obj-$(CONFIG_MTD_UBI) += ubi.o
is it not? why not just "obj-y"?
along those lines, again from drivers/mtd/Makefile:
obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/ tests/
obj-$(CONFIG_MTD_UBI) += ubi/
why not be consistent and have:
obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/
obj-$(CONFIG_MTD_UBI) += ubi/
obj-$(CONFIG_MTD_TESTS) += tests/
which would *massively* simplify drivers/mtd/tests/Makefile, would it
not?
i can submit some patches if there's any interest. i suspect some
of the other directories could be similarly tidied up.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: simplifying the linux MTD Kconfig/Makefile structure
2010-03-30 12:29 simplifying the linux MTD Kconfig/Makefile structure Robert P. J. Day
@ 2010-04-23 12:05 ` Artem Bityutskiy
2010-05-13 18:27 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2010-04-23 12:05 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: MTD mailing list
On Tue, 2010-03-30 at 08:29 -0400, Robert P. J. Day wrote:
> it seems like the various Kconfigs and Makefiles related to MTD
> could be tightened up a bit. for instance, in drivers/mtd/Makefile:
>
> obj-$(CONFIG_MTD_UBI) += ubi/
>
> but given that selection, it's kind of redundant to then have
> drivers/mtd/ubi/Makefile start with:
>
> obj-$(CONFIG_MTD_UBI) += ubi.o
>
> is it not? why not just "obj-y"?
>
> along those lines, again from drivers/mtd/Makefile:
>
> obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/ tests/
>
> obj-$(CONFIG_MTD_UBI) += ubi/
>
> why not be consistent and have:
>
> obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/
>
> obj-$(CONFIG_MTD_UBI) += ubi/
> obj-$(CONFIG_MTD_TESTS) += tests/
>
> which would *massively* simplify drivers/mtd/tests/Makefile, would it
> not?
>
> i can submit some patches if there's any interest. i suspect some
> of the other directories could be similarly tidied up.
Sounds like a reasonable clean-up to me.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: simplifying the linux MTD Kconfig/Makefile structure
2010-04-23 12:05 ` Artem Bityutskiy
@ 2010-05-13 18:27 ` Robert P. J. Day
0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2010-05-13 18:27 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: MTD mailing list
On Fri, 23 Apr 2010, Artem Bityutskiy wrote:
> On Tue, 2010-03-30 at 08:29 -0400, Robert P. J. Day wrote:
> > it seems like the various Kconfigs and Makefiles related to MTD
> > could be tightened up a bit. for instance, in drivers/mtd/Makefile:
> >
> > obj-$(CONFIG_MTD_UBI) += ubi/
> >
> > but given that selection, it's kind of redundant to then have
> > drivers/mtd/ubi/Makefile start with:
> >
> > obj-$(CONFIG_MTD_UBI) += ubi.o
> >
> > is it not? why not just "obj-y"?
> >
> > along those lines, again from drivers/mtd/Makefile:
> >
> > obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/ tests/
> >
> > obj-$(CONFIG_MTD_UBI) += ubi/
> >
> > why not be consistent and have:
> >
> > obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/
> >
> > obj-$(CONFIG_MTD_UBI) += ubi/
> > obj-$(CONFIG_MTD_TESTS) += tests/
> >
> > which would *massively* simplify drivers/mtd/tests/Makefile, would it
> > not?
> >
> > i can submit some patches if there's any interest. i suspect some
> > of the other directories could be similarly tidied up.
>
> Sounds like a reasonable clean-up to me.
sorry for the delay, either i or a local buddy will take care of
this and submit patches to the list.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-13 18:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-30 12:29 simplifying the linux MTD Kconfig/Makefile structure Robert P. J. Day
2010-04-23 12:05 ` Artem Bityutskiy
2010-05-13 18:27 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).