From: James Morris <jmorris@namei.org>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Andy Lutomirski <luto@amacapital.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
devel@openvz.org, Serge Hallyn <serge.hallyn@canonical.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-security-module@vger.kernel.org,
linux-mtd@lists.infradead.org, selinux@tycho.nsa.gov,
linux-fsdevel@vger.kernel.org,
Konstantin Khorenko <khorenko@virtuozzo.com>,
Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: [PATCH] fs: remove excess check for in_userns
Date: Wed, 23 Mar 2016 10:19:47 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.20.1603231019350.24906@namei.org> (raw)
In-Reply-To: <20160315134545.GB27754@ubuntu-xps13>
On Tue, 15 Mar 2016, Seth Forshee wrote:
> On Tue, Mar 15, 2016 at 03:09:00PM +0300, Pavel Tikhomirov wrote:
> > If in_userns returns false mnt_may_suid also returns false, and we
> > will reach second(removed) if-check only in case it does not trigger,
> > so remove it.
>
> We had a somewhat lengthy discussion previously where one of the
> conclusions was that we'd have that check in both places even though
> it's redundant. Iirc the reason was that though they're doing the same
> test they're doing so to answer different questions, so we should have
> the test in both places (or something along those lines).
A comment in the code might be useful here.
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2016-03-22 23:20 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 18:03 [PATCH RESEND v2 00/19] Support fuse mounts in user namespaces Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 01/18] block_dev: Support checking inode permissions in lookup_bdev() Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 02/18] block_dev: Check permissions towards block device inode when mounting Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 03/18] fs: Treat foreign mounts as nosuid Seth Forshee
[not found] ` <1458043740-14229-1-git-send-email-ptikhomirov@virtuozzo.com>
2016-03-15 13:45 ` [PATCH] fs: remove excess check for in_userns Seth Forshee
2016-03-22 23:19 ` James Morris [this message]
2016-01-04 18:03 ` [PATCH RESEND v2 04/18] selinux: Add support for unprivileged mounts from user namespaces Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 05/18] userns: Replace in_userns with current_in_userns Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 06/18] Smack: Handle labels consistently in untrusted mounts Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 07/18] fs: Check for invalid i_uid in may_follow_link() Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 08/18] cred: Reject inodes with invalid ids in set_create_file_as() Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 09/18] fs: Refuse uid/gid changes which don't map into s_user_ns Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 10/18] fs: Update posix_acl support to handle user namespace mounts Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 11/18] fs: Ensure the mounter of a filesystem is privileged towards its inodes Seth Forshee
2016-03-03 17:02 ` Seth Forshee
2016-03-04 22:43 ` Eric W. Biederman
2016-03-06 15:48 ` Seth Forshee
2016-03-06 22:07 ` Eric W. Biederman
2016-03-07 13:32 ` Seth Forshee
2016-03-28 16:59 ` Seth Forshee
2016-03-30 1:36 ` Eric W. Biederman
2016-03-30 14:58 ` Seth Forshee
2016-03-30 20:18 ` Eric W. Biederman
2016-01-04 18:03 ` [PATCH RESEND v2 12/18] fs: Don't remove suid for CAP_FSETID in s_user_ns Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 13/18] fs: Allow superblock owner to access do_remount_sb() Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 14/18] capabilities: Allow privileged user in s_user_ns to set security.* xattrs Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 15/18] fuse: Add support for pid namespaces Seth Forshee
2016-03-09 10:53 ` Miklos Szeredi
2016-03-09 14:17 ` Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 16/18] fuse: Support fuse filesystems outside of init_user_ns Seth Forshee
2016-03-09 11:29 ` Miklos Szeredi
2016-03-09 14:18 ` Seth Forshee
2016-03-09 14:48 ` Miklos Szeredi
2016-03-09 15:25 ` Seth Forshee
2016-03-09 15:51 ` Miklos Szeredi
2016-03-09 17:07 ` Seth Forshee
2016-03-14 20:58 ` Miklos Szeredi
2016-03-25 20:31 ` Seth Forshee
2016-01-04 18:03 ` [PATCH RESEND v2 17/18] fuse: Restrict allow_other to the superblock's namespace or a descendant Seth Forshee
2016-03-09 11:40 ` Miklos Szeredi
2016-01-04 18:03 ` [PATCH RESEND v2 18/18] fuse: Allow user namespace mounts Seth Forshee
2016-03-09 13:08 ` Miklos Szeredi
2016-01-25 19:47 ` [PATCH RESEND v2 00/19] Support fuse mounts in user namespaces Seth Forshee
2016-01-25 20:01 ` Eric W. Biederman
2016-01-25 20:36 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1603231019350.24906@namei.org \
--to=jmorris@namei.org \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=khorenko@virtuozzo.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=ptikhomirov@virtuozzo.com \
--cc=selinux@tycho.nsa.gov \
--cc=serge.hallyn@canonical.com \
--cc=seth.forshee@canonical.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox