From: "Jörn Engel" <joern@barelysecure.org>
To: Tal Zussman <tz2294@columbia.edu>
Cc: Joern Engel <joern@lazybastard.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] mtd: block2mtd: convert to folios
Date: Thu, 15 Oct 2026 11:39:18 -0700 [thread overview]
Message-ID: <atEd1rbZ_TCXpqXd@cashel.logfs.org> (raw)
In-Reply-To: <20261014-block2mtd-folio-v1-0-19d24ae676ee@columbia.edu>
On Wed, Oct 14, 2026 at 11:34:53PM -0400, Tal Zussman wrote:
>
> The numbers below are from mtd_speedtest, in MiB/s, by folio size,
> except the last row, which is from the MEMERASE ioctl:
>
> +------------------------------+-------+--------+---------+---------+
> | Test | Folio | Base | Patched | Change |
> +------------------------------+-------+--------+---------+---------+
> | Eraseblock read (128 KiB) | 4K | 12545 | 12863 | +2.5% |
> | | 16K | 12998 | 17229 | +32.6% |
> | | 64K | 13009 | 19135 | +47.1% |
> +------------------------------+-------+--------+---------+---------+
Thank you! Code size goes down, code seems subjectively easier to read
and performance goes up. Good stuff!
The one pet complaint I have is that benchmarks should measure badness,
not goodness. Humans tend to prioritize the big numbers. If you
measure the bad thing (time in this case), they focus on the worst areas
where most time is spent. If you measure the good thing, they tend to
improve things that are already too good to worry about even further.
Maybe you are immune to such psychological effects, but I am not and
measuring time instead of throughput makes a difference to my mind.
Jörn
--
The cheapest, fastest and most reliable components of a computer
system are those that aren't there.
-- Gordon Bell, DEC labratories
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2026-10-15 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 3:34 [PATCH 0/3] mtd: block2mtd: convert to folios Tal Zussman
2026-10-15 3:34 ` [PATCH 1/3] mtd: block2mtd: convert block2mtd_read() " Tal Zussman
2026-10-15 3:34 ` [PATCH 2/3] mtd: block2mtd: convert _block2mtd_write() " Tal Zussman
2026-10-15 3:34 ` [PATCH 3/3] mtd: block2mtd: convert _block2mtd_erase() " Tal Zussman
2026-10-15 3:45 ` sashiko-bot
2026-10-15 9:14 ` Miquel Raynal
2026-10-15 15:19 ` Tal Zussman
2026-10-15 18:34 ` Jörn Engel
2026-10-15 18:39 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atEd1rbZ_TCXpqXd@cashel.logfs.org \
--to=joern@barelysecure.org \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tz2294@columbia.edu \
--cc=vigneshr@ti.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox