linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Cernekee <cernekee@gmail.com>
To: <dedekind1@gmail.com>, <saeed.bishara@gmail.com>, <jwboyer@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: [PATCH 4/5] libmtd: add support for 64-bit offsets, OOB
Date: Mon, 5 Jul 2010 15:10:37 -0700	[thread overview]
Message-ID: <b025d903aab9bff2a1f0ddadff7f31a8@localhost> (raw)
In-Reply-To: <4822394121cd0a8f08b0bd3ecd6af199@localhost>

Change mtd_erase() so that it attempts to use MEMERASE64 first, then falls
back to the old <2.6.31 MEMERASE if MEMERASE64 is unsupported.

Add mtd_read_oob(), mtd_write_oob() functions to wrap the OOB ioctls.
Similar ioctl fallback logic is used in these functions as well.

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
---
 include/libmtd.h |   26 +++++++++++++++++++++
 lib/libmtd.c     |   65 +++++++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 88 insertions(+), 3 deletions(-)

diff --git a/include/libmtd.h b/include/libmtd.h
index 0aea966..2241343 100644
--- a/include/libmtd.h
+++ b/include/libmtd.h
@@ -149,6 +149,32 @@ int mtd_get_dev_info1(libmtd_t desc, int mtd_num, struct mtd_dev_info *mtd);
 int mtd_erase(const struct mtd_dev_info *mtd, int fd, int eb);
 
 /**
+ * mtd_read_oob - read OOB bytes
+ * @fd: MTD device node file descriptor
+ * @start: page-aligned start address
+ * @length: number of OOB bytes to read
+ * @data: read buffer
+ *
+ * This function reads @length OOB bytes starting from address @start on
+ * MTD device described by @fd. Returns %0 in case of success and %-1 in
+ * case of failure.
+ */
+int mtd_read_oob(int fd, uint64_t start, uint64_t length, void *data);
+
+/**
+ * mtd_write_oob - write OOB bytes
+ * @fd: MTD device node file descriptor
+ * @start: page-aligned start address
+ * @length: number of OOB bytes to write
+ * @data: write buffer
+ *
+ * This function writes @length OOB bytes starting from address @start on
+ * MTD device described by @fd. Returns %0 in case of success and %-1 in
+ * case of failure.
+ */
+int mtd_write_oob(int fd, uint64_t start, uint64_t length, void *data);
+
+/**
  * mtd_torture - torture an eraseblock.
  * @mtd: MTD device description object
  * @fd: MTD device node file descriptor
diff --git a/lib/libmtd.c b/lib/libmtd.c
index 3ff031c..368493b 100644
--- a/lib/libmtd.c
+++ b/lib/libmtd.c
@@ -32,6 +32,7 @@
 #include <sys/stat.h>
 #include <sys/ioctl.h>
 #include <mtd/mtd-user.h>
+#include <mtd/mtd-abi.h>
 
 #include <libmtd.h>
 #include "libmtd_int.h"
@@ -791,11 +792,69 @@ int mtd_get_dev_info(libmtd_t desc, const char *node, struct mtd_dev_info *mtd)
 
 int mtd_erase(const struct mtd_dev_info *mtd, int fd, int eb)
 {
-	struct erase_info_user ei;
+	int ret;
+	struct erase_info_user64 ei;
 
-	ei.start = eb * mtd->eb_size;;
+	ei.start = (__u64)eb * mtd->eb_size;
 	ei.length = mtd->eb_size;
-	return ioctl(fd, MEMERASE, &ei);
+	ret = ioctl(fd, MEMERASE64, &ei);
+
+	if (ret < 0 && errno == ENOTTY) {
+		struct erase_info_user ei_old;
+
+		ei_old.start = (__u32)ei.start;
+		ei_old.length = (__u32)ei.length;
+
+		if (ei_old.start != ei.start) {
+			errno = EOVERFLOW;
+			return -1;
+		}
+
+		ret = ioctl(fd, MEMERASE, &ei_old);
+	}
+
+	return ret;
+}
+
+static int mtd_oob_op(int cmd, int cmd_old, int fd, uint64_t start,
+	uint64_t length, void *data)
+{
+	int ret;
+	struct mtd_oob_buf64 oob;
+
+	oob.start = start;
+	oob.length = length;
+	oob.usr_ptr = (__u64)(unsigned long)data;
+
+	ret = ioctl(fd, cmd, &oob);
+
+	if (ret < 0 && errno == ENOTTY) {
+		struct mtd_oob_buf oob_old;
+
+		oob_old.start = (__u32)oob.start;
+		oob_old.length = (__u32)oob.length;
+		oob_old.ptr = data;
+
+		if (oob_old.start != oob.start ||
+				oob_old.length != oob.length) {
+			errno = EOVERFLOW;
+			return -1;
+		}
+
+		ret = ioctl(fd, cmd_old, &oob_old);
+	}
+
+	return ret;
+}
+
+int mtd_read_oob(int fd, uint64_t start, uint64_t length, void *data)
+{
+	return mtd_oob_op(MEMREADOOB64, MEMREADOOB, fd, start, length, data);
+}
+
+int mtd_write_oob(int fd, uint64_t start, uint64_t length, void *data)
+{
+	return mtd_oob_op(MEMWRITEOOB64, MEMWRITEOOB, fd, start, length, data);
 }
 
 /* Patterns to write to a physical eraseblock when torturing it */
-- 
1.6.5

  parent reply	other threads:[~2010-07-05 22:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05 22:10 [PATCH 1/5] mtd-utils: move libmtd source files to lib/ subdirectory Kevin Cernekee
2010-07-05 22:10 ` [PATCH 2/5] mtd-utils: update Makefiles, source files to use common libmtd.a Kevin Cernekee
2010-07-05 22:10 ` [PATCH 3/5] mtd-utils: update to latest mtd-abi.h from kernel.org Kevin Cernekee
2010-07-05 22:10 ` Kevin Cernekee [this message]
2010-07-05 22:58   ` [PATCH 4/5] libmtd: add support for 64-bit offsets, OOB Mike Frysinger
2010-07-06  4:02   ` Artem Bityutskiy
2010-07-05 22:10 ` [PATCH 5/5] mtd-utils: change flash_eraseall to use libmtd-wrapped ioctls Kevin Cernekee
2010-07-05 22:53 ` [PATCH 1/5] mtd-utils: move libmtd source files to lib/ subdirectory Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b025d903aab9bff2a1f0ddadff7f31a8@localhost \
    --to=cernekee@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=jwboyer@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=saeed.bishara@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).