From: Xiaoming Ni <nixiaoming@huawei.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: zhangweimin12@huawei.com, vigneshr@ti.com, richard@nod.at,
wangle6@huawei.com, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success
Date: Wed, 25 Mar 2020 15:53:41 +0800 [thread overview]
Message-ID: <b37235a2-d949-7f78-770b-4a69d9d7aaaa@huawei.com> (raw)
In-Reply-To: <20200324230620.174db1a7@xps13>
On 2020/3/25 6:06, Miquel Raynal wrote:
> Hi Xiaoming,
>
> Xiaoming Ni <nixiaoming@huawei.com> wrote on Fri, 20 Mar 2020 11:15:11
> +0800:
>
>> mtdblock_flush()
>> -->write_cached_data()
>> --->erase_write()
>> mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed
>>
>> Because mtdblock_flush() always returns 0,
>> even if write_cached_data() fails and data is not written to the device,
>> syscall_write() still returns success
>
> I reworded a bit the commit log and also added a ' ' after 'mtd:' in
> the title when applying.
>
> Thanks,
> Miquèl
Your revised commit log is more accurate and clearer, thanks for your
correction
Thanks.
Xiaoming Ni
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-03-25 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 3:15 [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success Xiaoming Ni
2020-03-24 22:05 ` Miquel Raynal
2020-03-24 22:06 ` Miquel Raynal
2020-03-25 7:53 ` Xiaoming Ni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b37235a2-d949-7f78-770b-4a69d9d7aaaa@huawei.com \
--to=nixiaoming@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=wangle6@huawei.com \
--cc=zhangweimin12@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox