Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>
Cc: devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
	Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: spi-nor: add rockchip serial flash controller driver
Date: Fri, 25 Nov 2016 14:54:24 +0100	[thread overview]
Message-ID: <b513a489-5913-ffe8-69f1-7201943a05a3@gmail.com> (raw)
In-Reply-To: <76670120-dacd-ef0e-cf36-cbf549b19853@rock-chips.com>

On 11/21/2016 03:51 AM, Shawn Lin wrote:
> Hi Marek,

Hi!

[...]

>>> sfc->num_chip stands for how many flashes registered successfully.
>>
>> Does it work if you have a hole in there ? Like if you have a flash on
>> chipselect 0 and chipselect 2 ?
> 
> Yes it does, as it won't leave a room for chipselect 1 whose node isn't
> present, which means there isn't a hole in there at all. :)

Ah , because you are not indexing those NORs with their CS number , right ?


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2016-11-25 13:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11  9:16 [PATCH 0/2] Add rockchip serial flash controller support Shawn Lin
2016-11-11  9:16 ` [PATCH 1/2] mtd: spi-nor: Bindings for Rockchip serial flash controller Shawn Lin
2016-11-15 15:05   ` Rob Herring
2016-11-11  9:16 ` [PATCH 2/2] mtd: spi-nor: add rockchip serial flash controller driver Shawn Lin
2016-11-15 20:52   ` Marek Vasut
2016-11-16  1:59     ` Shawn Lin
2016-11-20 21:11       ` Marek Vasut
2016-11-21  2:51         ` Shawn Lin
2016-11-25 13:54           ` Marek Vasut [this message]
2016-11-30  0:57             ` Shawn Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b513a489-5913-ffe8-69f1-7201943a05a3@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=heiko@sntech.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox