From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AEF0C433F5 for ; Wed, 16 Mar 2022 07:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yZxdLIk9lqWMA1/m8Hbu+eCBpU2eHgBOtVan4sGF+38=; b=DgO/0AYjsMQjUd uhiVCgds5X5IRH8eEX9fEPY4u9JKjkOPffiT2cW4ZneYjQC3z6bJiM55S0iH8R/MhIhw1Ub6lNGRP n/t1vBN6W4gO57CyK8Jj6/+wWQBb+hCDax65rlILFlrbpAHArK80WXwrOQ3wuKRpONEJP4TUcr/w7 0IIxXy2wdfJbTRXBQyc7LE8NALN8/rJyzkliUe2IlUqSEA8a61yM9GSEKJE+hqTuTNngeQUlpnnjs kZgYTYa/qGWTYsVZeanG3j3K4zc4PMcEtnr2iNxM9nB3F4SyDznWkvDZdfRxktX+twExbrWKUhp1H taZibicq3gn7QAy5GKxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUONs-00C0UQ-P3; Wed, 16 Mar 2022 07:47:52 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUONp-00C0Sr-Bk for linux-mtd@lists.infradead.org; Wed, 16 Mar 2022 07:47:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1647416869; x=1678952869; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1sCLpyC6a6fsxn19cvhK/sZpvKemstT65YqGTWDYZLU=; b=bsNTbhlTzqJH5HkWQPnJiwC/irHhMo5VyDUh3bYBRLwTPURUzwfT9RZZ vR/YmIoUOpf5S+G/8TEuj3FFUiKGjvUhaErf9e/mcK5W6seP2vQrjSI4k qeK7ro6Hvt0mDBgyCO0BR6eSmu4+P0PhAjnpB8s+Vk0FebZ1cri+PXk3X axYIOakIGDYV/Z2c2xEXsqMu0x6UWh18bydVqAavmTgvV01V1IQWxuKr/ yq1XR0LMYSzFwqIwbPTxEjNb00zM2CJNZRtsJqTUWT6p5XsYTcO90OCHO hRx8FmXeZRe7qvUVZlqaXmNtDRZ8H4IPFTOvp9c5re8/J3LWKt8JQJC+Z A==; X-IronPort-AV: E=Sophos;i="5.90,186,1643698800"; d="scan'208";a="89087735" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 16 Mar 2022 00:47:45 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 16 Mar 2022 00:47:45 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Wed, 16 Mar 2022 00:47:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5PmZYsK8eWBTkSsgDB29lqLFXyjPOHYBmBRQj5LlIzbVdavTuNkql3zCIQoQ7yv0G6HtiOMJWq9aMfZm2hblN+0i6qvWws2wNzWtilv4ilU7a2qFDWHyegnCVy4VMlrmlLDdf4mnD50RFCufMIAtyXL9SEkN7gir4ilYbCrFRXKB28aiqvOCZUS8whFXtOnkDw/or8993PRZubHBXfEhg78ahbu3LKdXVr5FiKioTw/gpQuF/jqJZjGiLoww2cGeJ5uXzipyn4KyVsXjMUZEJOHFm+JBh+2P/UJxerxcb0uzJdfL9O85dEBaE4X5t6oUYSwcVFVdkQ5EonQ/flJcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1sCLpyC6a6fsxn19cvhK/sZpvKemstT65YqGTWDYZLU=; b=FSdCk6DWkPplrGkiycyDit4udTohKX59TesTNEgqZvaUPgUslL2irNcYSphg1ZuQwHQ3opSx1Az9IYRpcAwKfKXk1/U4UiulXCHqteGli6xyP2sIucG4QQ6mJMY2E5ePKwr34ctu/8M4mZg8HHAhcKA9CrkrtY3j9wfx2ka9gGDDdmZ88j9MVc+HJMTjXJw96RILzZOs/KefLfRvr8SYc3pLBP6aofgEjJPvYjytiszxsbDMcudbu23RPiIK3Cydjj1EP5YYQe4iPDCAs1xEugDpX2Y6NehauNn6L2vGYKnMYaKoT87N7N+EtkILEytRAqk91ErKSh83hknoU6SVWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1sCLpyC6a6fsxn19cvhK/sZpvKemstT65YqGTWDYZLU=; b=ihpl+XkyR5iAL4m5LxiwlVw9vq2mx88qEUSJSYKR0gM63/bRjCaDRNcN27pfwYqe7NfpFHuzR7U4nhKGL6GUJU9J6r+ScOH21ovuwiQUp/PgKI8Iue6RMU2gLgj5ZfzsuogpDe1gefwA2ENNTXRC5aNDDQqsF4rqctK2w1PjFhw= Received: from SA2PR11MB4874.namprd11.prod.outlook.com (2603:10b6:806:f9::23) by BL0PR11MB3155.namprd11.prod.outlook.com (2603:10b6:208:68::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Wed, 16 Mar 2022 07:47:40 +0000 Received: from SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::dc94:3c7c:8ef8:21b9]) by SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::dc94:3c7c:8ef8:21b9%5]) with mapi id 15.20.5061.028; Wed, 16 Mar 2022 07:47:40 +0000 From: To: , CC: , , , Subject: Re: [PATCH 1/2] mtd: spi-nor: Fix shift-out-of-bounds Thread-Topic: [PATCH 1/2] mtd: spi-nor: Fix shift-out-of-bounds Thread-Index: AQHYOQodYTda3weuU0+yf380GWE6EQ== Date: Wed, 16 Mar 2022 07:47:40 +0000 Message-ID: References: <20211106075616.95401-1-tudor.ambarus@microchip.com> <20211106075616.95401-2-tudor.ambarus@microchip.com> <5550605.DvuYhMxLoT@steina-w> In-Reply-To: <5550605.DvuYhMxLoT@steina-w> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 71e7b21a-2b15-4626-5887-08da07213f98 x-ms-traffictypediagnostic: BL0PR11MB3155:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4II6D7W0QAm4y1TQICSwl6z+4PxAjTtw6ZYyxYYJHKFiqQsnyzAvHDAilvtmPlh6kre13uTz3+YDvxTSS0mCpZjYH/vcIW2jal2QsBrtyRjDmguhdBeYoFgfoa0Rb9kH2FnsIW24rdZpsEklox0sJMp6jQTPMBUHFO0EgEUKnwZYU/TmpwFkcB7SX2pvyJBRBoMfS9lgFEufbqWQ/fDoNz4rGvGdgwl1JtRI43L9evPVxXmRAiVkC9xxEWbqdhnlrAkBlIc0J1qDChkK9xr6459TZEqXopWzhgh+d/4Z5rRdGxryLB+OIaAq4KRhHJQKOjUaEgwaGq+RSKLxFbNbj4xdBEM4tek7sRj+PopYJ5UO6moRR44DOeUYZh2Cjs4aZYTDoWA7NOkk5rdUq/8LsPPyTlEzSXtKZotYUpIQ7sTrJvXOEabeWOO3CnNHcJWsj04mdi6p1tht9z+Co6hJpUNgV8FuD3/VMYFAL8CVzcqLR1Fq9z8OkDPRUHhsgMlojRnSZbN+u8v4B9lIEprjFXQJBdJO5Q4HYL+PMjmAyrDk4djMNPor65TC7JyT2CDNH0UOWRlh8PkbQJr9St1HvK0lXiG5mWaiXdO3d3iLCMmAYL6JfIZSSZoeEfNHivywiaK4AiF20Xo52wvan2rUgfbNbb66a1oUuxzGPMTCRf5uguCed7gBdIYQASVSdUT4qsAfB7xKYSF33zzU+kOEz67tI5xFbewlIFzzi29254JKJC+/h/Vwejd8OyQFdRn9ybFsQIuMbn6Z3UNman4qAGfG3e5kMyW6wvxdV6VlXdNFsMzoFlZVOAxrxjYzkA5r x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB4874.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(6506007)(6512007)(53546011)(66476007)(66556008)(66446008)(8676002)(66946007)(316002)(54906003)(110136005)(76116006)(64756008)(4326008)(91956017)(122000001)(71200400001)(38100700002)(2616005)(186003)(8936002)(31696002)(5660300002)(26005)(83380400001)(2906002)(38070700005)(508600001)(31686004)(966005)(6486002)(36756003)(43740500002)(45980500001)(10090945011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RmNONzlPTHpwdDBVMEU4MmZwNzBYNGR5VXRkODFiT2lVT1Y1anp5ZnB2Unhj?= =?utf-8?B?MnVCTlZjK1BZV1FWUEcybnQrUkk1YURGZzVCWnM3by9Vbm94VWowY2dnT3dp?= =?utf-8?B?KzcrbzZRTFhtbGo4UHlrQ0tEMTVJYVZRRFl6RytyZUw0OVE1WVpBUnc1V2hE?= =?utf-8?B?OUdzQXBiQlNJQmlVc3ZSSWRQZlN3Vzc0UmQ2S05wcWdBZEdmSmlLMTJnMVgz?= =?utf-8?B?WUI0T1FlR1pYM2RWajhCNDBSclVoTEptQUNOeHhNbWFXQ3lKWk4yYmNJWGdJ?= =?utf-8?B?ZFV1VTBPRDVURFZIL1JvOThIWjgxa25LbmQwaVlHOE9pY1MwNDhYSlpuWnpa?= =?utf-8?B?L0gzWFBqTjFELytzUHk1MHN0YXNCTEUyQWJIYTRMc2VmV1hhdTROYTBqL3hR?= =?utf-8?B?NkpkRnBNQkl0cldkM1pkNUI4cGdGNjVJOU1GdlJLdnc3Q0tSTkJpaHdOcnZr?= =?utf-8?B?Ti9ydHlVTUFYVkFXWW5zcmNMSEZjOXVhK0xPRjM4OVJZZmxGeWVJbWNuZE5Z?= =?utf-8?B?UFp2aWZXeGo2MFZ2RnNCazlqNWdtWkFkTWtxNCtWdDNZRmF1aERvRjQ1VS9k?= =?utf-8?B?dFVSc2g0SElwbk1xQTQ0MkdYdDFJTW5uTnk2OUd1Z0gxTEVPM3YvSFpMWjlX?= =?utf-8?B?cVZtV3BSa2pZcjhrUGxRak9KSHRENXZETXFkMmFpYnB1Q2Ewc3FBdDMvTWhV?= =?utf-8?B?dU90dDFZOVppbVhFNE1LZGdQN0xNeTBhYkxaS1REemQ3cHN3QmYzN1V3VVMx?= =?utf-8?B?RlhCNG1CWkNSMHM4Z3BZNjR4YXZoNE9LRHVDbnRtVEtNa3I5WDBCblZjMFVo?= =?utf-8?B?d0ZYN2c5R0VGaU16VmpUQXdXcVlYMUpZT0NOSGRYRkp2bkpmS05BK0hlbVNO?= =?utf-8?B?OW1WREpoVGV6b1lWaHNWSmY0cU1mTHZhUjJ6ZVlqc2lvVTY3L2NmTWZKNzlT?= =?utf-8?B?OENTTjlKNlMvMnpWcXNOWVFwaFEybjY0WWpEMFFqOW4xeW43NFIxdEcwZjF1?= =?utf-8?B?VitUS3VpVEZEeEduRDQrQXNOODJBL3RiVVY5TFdGN2k4YmtNNzdBVTBIc29I?= =?utf-8?B?WUJGRm9JL0UvU3NNZ1JWcUZmblhNOU9XbWJiNWlOWjlrK3lKeEVOOHNnVjlG?= =?utf-8?B?OU9JSDZaZ1B1VjZoMXFRV2RiMVhBUkxTamNmeTJOQ3hLUURhVkVnVG1QbzNM?= =?utf-8?B?eFhtaVk2Si9RVHo5emRTaVF2czJ5TEFYNzB1RjV6SU5QYmdjNkp3dzRBaDZu?= =?utf-8?B?MkwwVnR4L042NERSQTViWDhiY3ozZlpQbUxhbk5nZEFBT0VEbWM3eTdiM1Iy?= =?utf-8?B?WDk1cng3SHhFUExBckZPQmJaTDlOMFFlVzdHODVna2ZaVlZzd3NjUzRESUpm?= =?utf-8?B?WEZnelNxQlA2R29heTRuN3NXZWZtZFhvYWxtaGgrazNqSERheWFBWlNGN0R2?= =?utf-8?B?ZENEandsa1paeEJoTWN1akVVbTNmOE9NL3RsSzhYaXppUnRjYVVTRHpoT1BZ?= =?utf-8?B?cnllakVvM1JYaUxYekVFZ29La1NkSlczUDRvZk1PUlpQVmZ0MExMcUw0VDZR?= =?utf-8?B?QVNCaWY3WmtBSzJ3UGUvZm5KZnoyVzMvclIxSDl5LzhOd0tvLzlpL0dCVmtQ?= =?utf-8?B?bDNod0pDVnRxUmlQbVRIYVprYjQ3WGZ6aEZETFk2ek5wN2NVVHNlU2ZVWjl5?= =?utf-8?B?anhTVmV6VFR6L2JtQXJtMjdhOEtLY3Q4c3lYdjgwZFphSEQ3clQ0VGJFOFF2?= =?utf-8?B?L0xBTTI4c215aDQ4V0U1dGFycFFnNTR4cVI4Z251NGFDOStsTnRHTU9ST1lX?= =?utf-8?B?aXdQc0xpdjQ5b3UwL1drRHh5YVErSnJTbGZ0dms4VFpTbXdSTmVodnl2UjA2?= =?utf-8?B?UDV1LzJpUWJhSklxaWRmK24zc0RsWUNQelBBaEQwUTNNNXFuOGFMVUxzREZw?= =?utf-8?B?RlBFZGYyZDQ0VGRQcEp3Vk9QQjlKbUorYVhFVlRrSDVZNG9lb1lCRXdKL1BI?= =?utf-8?B?WCtxTk9UYXhnPT0=?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4874.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71e7b21a-2b15-4626-5887-08da07213f98 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 07:47:40.7829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DHqGbf8+smFIWTnBAbAz/CGjjxwAiJVz6+ZfApQPL+tIpy9ep2XTFhJlqzLgdLYw/XSOI5eFen6Z53TSVleHkqFvifoNR+ICFhwhkJbXw8Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3155 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_004749_583214_87A2B76F X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 3/16/22 09:39, Alexander Stein wrote: > [You don't often get email from alexander.stein@tq-group.com. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hello, hi, > > Am Samstag, 6. November 2021, 08:56:15 CET schrieb Tudor Ambarus: >> When paring SFDP we may choose to mask out an erase type, passing >> an erase size of zero to spi_nor_set_erase_type(). >> Fix shift-out-of-bounds and just clear the erase params when >> passing zero for erase size. >> While here avoid a superfluous dereference and use 'size' directly. >> >> UBSAN: shift-out-of-bounds in drivers/mtd/spi-nor/core.c:2237:24 >> shift exponent 4294967295 is too large for 32-bit type 'int' >> >> Fixes: 5390a8df769e ("mtd: spi-nor: add support to non-uniform SFDP SPI NOR >> flash memories") Reported-by: Alexander Stein >> >> Signed-off-by: Tudor Ambarus >> --- >> drivers/mtd/spi-nor/core.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c >> index 3d97c189c332..a1b5d5432f41 100644 >> --- a/drivers/mtd/spi-nor/core.c >> +++ b/drivers/mtd/spi-nor/core.c >> @@ -2230,8 +2230,13 @@ void spi_nor_set_erase_type(struct spi_nor_erase_type >> *erase, u32 size, erase->size = size; >> erase->opcode = opcode; >> /* JEDEC JESD216B Standard imposes erase sizes to be power of 2. */ >> - erase->size_shift = ffs(erase->size) - 1; >> - erase->size_mask = (1 << erase->size_shift) - 1; >> + if (size) { >> + erase->size_shift = ffs(size) - 1; >> + erase->size_mask = (1 << erase->size_shift) - 1; >> + } else { >> + erase->size_shift = 0; >> + erase->size_mask = 0; >> + } >> } >> >> /** > > What is the status of this patch? It is not applied up until now, no? Has it > been superseeded? > I think it's marked with "changes requested". I'm going to send a v2. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/