From: Roger Quadros <rogerq@ti.com>
To: Ladislav Michl <ladis@linux-mips.org>, <linux-mtd@lists.infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata
Date: Fri, 13 Oct 2017 15:06:27 +0300 [thread overview]
Message-ID: <ba3bdf7e-fae9-0541-756a-b1447ffb2dc6@ti.com> (raw)
In-Reply-To: <20171010133245.jlwto3gpmin5bmtw@lenoch>
Hi,
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 10/10/17 16:32, Ladislav Michl wrote:
> commit 67ce04bf2746 ("mtd: nand: add OMAP2/OMAP3 NAND driver") assigned
> pointer to omap_nand_info to the platform drvdata in probe function
> just to be reasigned later to the pointer to mtd_info, which is
> what remove function expects it to be. Remove useless assignment.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Tested on dra7-evm.
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 01368a8f9e3f..a97c1aeed55e 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1823,7 +1823,6 @@ static int omap_nand_probe(struct platform_device *pdev)
> if (err)
> return err;
>
> - platform_set_drvdata(pdev, info);
> info->ops = gpmc_omap_get_nand_ops(&info->reg, info->gpmc_cs);
> if (!info->ops) {
> dev_err(&pdev->dev, "Failed to get GPMC->NAND interface\n");
>
--
cheers,
-roger
next prev parent reply other threads:[~2017-10-13 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 13:32 [PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata Ladislav Michl
2017-10-13 12:06 ` Roger Quadros [this message]
2017-10-14 15:11 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba3bdf7e-fae9-0541-756a-b1447ffb2dc6@ti.com \
--to=rogerq@ti.com \
--cc=boris.brezillon@free-electrons.com \
--cc=ladis@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox