From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB994C0015E for ; Tue, 25 Jul 2023 03:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Nl9VIemzXjtGOoOQy1aBqm/Vt/8Q/6khYvhiLhzxMw=; b=GzzimLPhUMLjtx L2tpGT0DPy7/8accKDYNjd5iUxXPScxlE7tIv+DSzwHu8FKjXk/wg+A8+ra41o1YAIim8f/QEQ0/O EJv0wOPorN8/0Q2jxnehzeu8FeNsf94rCdvv6CYb/UkA8Y4UBcnzSn6iYIpLZqVtxQaH0FAMTOJzz dydVSZl5bmpvygELDNfy3l827Ey0JX9ovpPdYtXf2PaU4UdJlw+qItpRNDJvsQ+0NMY22/zkZtWu0 Rx4wttcrUefUtHI2JKHpxx9IFbAj8CtxWL4HmxatBKo1b2/cJwFNIspXjPr2uJz78ZC9d27eTC8Sv Y8fJA9n3pwfT7HKyqa9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qO8ig-0062SO-24; Tue, 25 Jul 2023 03:28:18 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qO8ic-0062QU-2C for linux-mtd@lists.infradead.org; Tue, 25 Jul 2023 03:28:17 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-66d6a9851f3so1183675b3a.0 for ; Mon, 24 Jul 2023 20:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690255690; x=1690860490; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6wY4cILkEhsrpRf+mNddP0nleKOSU9sayj8Z5h0ToXM=; b=PknHptOa2Z8+2vaclzexjcjHcgGTKnQ0JRJ89LK+GvkJZyUzNmFYDaw4LaxhrbAB97 Qlt49eA21cgLfip1YkLzQvNHl9NRE1uu+H3yLMzr5GUQw2R94ASja3LKRc7K2/IuJ877 /rUQws3HOX4h/pSV0QLIC/txctttQBZDy4goWlpNGxYwzk8J6CttdGDNpskz9IiWFE6E W06R7YBvAlwN2Ll/k0WZ+e8J2UJKgy2rlagtK3lUaqPgpyCrwLsDTNoP/0MXBrAUaLK4 fe8VXE6m3BmotnBeZ7KmASyzpGnPX5FsNzpJdMUNn5TjD0dfcmx5lygJuqraNOT+sjor yB3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690255690; x=1690860490; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6wY4cILkEhsrpRf+mNddP0nleKOSU9sayj8Z5h0ToXM=; b=jBB0c/2WOR62nz+ao5r32DCJEFV3qTmYpz3FaIW6ZZQT5DxRQFjr2wQ5QGcuQdF3NY YDj0Ycag7jOp4L/PZ4f7nkQ0gN2BinnTGlzpCIMjqUTWwMRn/G8w//qRxH4AbuKBVEdh HYRauO+D6zCm7Pp/88O5UknsAhGf+MwDrPhlFZHi+VKPbbQ2Pgfw/H+xuQKtcYcPh3mp bpB9vRi6FVhILqlo94aNN5Rr2BsxxX7croy7TKw15C5kbfNu1/rCzIzWzaLqXFgvlCVl T8do60O4BhiraTppG3EsaDq/PyWO7Jd973UKpxNbEyAzfP97yN1p4KUFgUGUlbk9nI5h lZrQ== X-Gm-Message-State: ABy/qLbsaC4DOVGyBSaRxv3P22szGP2ZoxgVyQ7o4sYkXheq8E+ElgQf x0pxMWhiBK3DgqapJLsGRCi9WA== X-Google-Smtp-Source: APBJJlHvnzRChS6v/nee9rDGEWxm9C29UVXVwYKOSH3HP5ue/guAsHAKmcdiSeukVqd30tCkGAz2cw== X-Received: by 2002:a05:6a00:cd1:b0:677:bb4c:c321 with SMTP id b17-20020a056a000cd100b00677bb4cc321mr15272930pfv.0.1690255690395; Mon, 24 Jul 2023 20:28:10 -0700 (PDT) Received: from ?IPV6:fdbd:ff1:ce00:1c25:884:3ed:e1db:b610? ([240e:694:e21:b::2]) by smtp.gmail.com with ESMTPSA id s3-20020aa78283000000b00682a9325ffcsm8407714pfm.5.2023.07.24.20.27.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 20:28:10 -0700 (PDT) Message-ID: Date: Tue, 25 Jul 2023 11:27:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file Content-Language: en-US To: Muchun Song Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , LKML , Linux Memory Management List , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-2-zhengqi.arch@bytedance.com> <97E80C37-8872-4C5A-A027-A0B35F39152A@linux.dev> <6FE62F56-1B4E-4E2A-BEA9-0DA6907A2FA9@linux.dev> From: Qi Zheng In-Reply-To: <6FE62F56-1B4E-4E2A-BEA9-0DA6907A2FA9@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230724_202814_720658_79349C65 X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 2023/7/25 11:23, Muchun Song wrote: > > >> On Jul 25, 2023, at 11:09, Qi Zheng wrote: >> >> >> >> On 2023/7/25 10:35, Muchun Song wrote: >>>> On Jul 24, 2023, at 17:43, Qi Zheng wrote: >>>> >>>> The mm/vmscan.c file is too large, so separate the shrinker-related >>>> code from it into a separate file. No functional changes. >>>> >>>> Signed-off-by: Qi Zheng >>>> --- >>>> include/linux/shrinker.h | 3 + >>>> mm/Makefile | 4 +- >>>> mm/shrinker.c | 707 +++++++++++++++++++++++++++++++++++++++ >>>> mm/vmscan.c | 701 -------------------------------------- >>>> 4 files changed, 712 insertions(+), 703 deletions(-) >>>> create mode 100644 mm/shrinker.c >>>> >>>> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h >>>> index 224293b2dd06..961cb84e51f5 100644 >>>> --- a/include/linux/shrinker.h >>>> +++ b/include/linux/shrinker.h >>>> @@ -96,6 +96,9 @@ struct shrinker { >>>> */ >>>> #define SHRINKER_NONSLAB (1 << 3) >>>> >>>> +unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, >>>> + int priority); >>> A good cleanup, vmscan.c is so huge. >>> I'd like to introduce a new header in mm/ directory and contains those >>> declarations of functions (like this and other debug function in >>> shrinker_debug.c) since they are used internally across mm. >> >> How about putting them in the mm/internal.h file? > > Either is fine to me. OK, will do in the next version. > >> >>> Thanks. > > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/