From: Randy Dunlap <rdunlap@infradead.org>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR
Date: Sat, 11 Aug 2018 08:11:47 -0700 [thread overview]
Message-ID: <bbfb9a17-b02f-62b9-48bd-c9f1e604d0ea@infradead.org> (raw)
In-Reply-To: <20180811134712.2903-1-boris.brezillon@bootlin.com>
On 08/11/2018 06:47 AM, Boris Brezillon wrote:
> The driver uses genalloc functions. Select GENERIC_ALLOCATOR to prevent
> build errors when selected through COMPILE_TEST.
>
> Fixes: 88a40e7dca00 ("mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Changes in v2:
> - Use select instead of depends on (suggested by Thomas)
> ---
> drivers/mtd/nand/raw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index b6738ece16f1..5fc9a1bde4ac 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -279,6 +279,7 @@ config MTD_NAND_ATMEL
> tristate "Support for NAND Flash / SmartMedia on AT91"
> depends on ARCH_AT91 || COMPILE_TEST
> depends on HAS_IOMEM
> + select GENERIC_ALLOCATOR
> select MFD_ATMEL_SMC
> help
> Enables support for NAND Flash / Smart Media Card interface
>
--
~Randy
next prev parent reply other threads:[~2018-08-11 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 13:47 [PATCH v2] mtd: rawnand: atmel: Select GENERIC_ALLOCATOR Boris Brezillon
2018-08-11 14:05 ` Miquel Raynal
2018-08-11 14:10 ` Boris Brezillon
2018-08-11 15:11 ` Randy Dunlap [this message]
2018-08-12 8:17 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbfb9a17-b02f-62b9-48bd-c9f1e604d0ea@infradead.org \
--to=rdunlap@infradead.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).