From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Arseniy Krasnov <avkrasnov@sberdevices.ru>,
Liang Yang <liang.yang@amlogic.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: oxffffaa@gmail.com, kernel@sberdevices.ru,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] Meson NAND: waiting w/o wired ready/busy pin
Date: Wed, 7 Jun 2023 20:48:43 +0200 [thread overview]
Message-ID: <bd2d1770-9856-d022-5e91-6a2cdc302b73@linaro.org> (raw)
In-Reply-To: <a1e048aa-ec64-bd0b-aa17-e3e9bdf18090@sberdevices.ru>
On 07/06/2023 17:18, Arseniy Krasnov wrote:
>
>
> On 07.06.2023 17:50, Arseniy Krasnov wrote:
>> Main thing that this patchset adds is support for waiting for command
>> completion when there is no wired ready/busy pin. This is implemented
>> by using Meson specific command which operates without wired pin, but
>> supports interrupt driven waiting (default way for waiting without
>> hardware pin is 'nand_soft_waitrdy()' which uses software loop instead
>> of interrupt). To select which mode to use during driver initialization,
>> common NAND controller property is used - 'nand-rb'. It is described in
>> 'nand-controller.yaml'. But for Meson, its description was missed in
>> 'amlogic,meson-nand.yaml', so this patchset also adds support for it.
>>
>> Patch for bindings was tested with dt_binding_check and dtbs_check.
>>
>> Arseniy Krasnov (2):
>> dt-bindings: nand: meson: Fix 'nand-rb' property
>> mtd: rawnand: meson: waiting w/o wired ready/busy pin
>>
>> .../bindings/mtd/amlogic,meson-nand.yaml | 7 ++
>> drivers/mtd/nand/raw/meson_nand.c | 82 ++++++++++++++++++-
>> 2 files changed, 85 insertions(+), 4 deletions(-)
>>
>
> Changelog:
> * Two separate patches:
> For bindings: https://lore.kernel.org/linux-mtd/20230606193507.35024-1-AVKrasnov@sberdevices.ru/
> For driver: https://lore.kernel.org/linux-mtd/20230607073015.1280085-1-AVKrasnov@sberdevices.ru/
> Now fixed/updated and combined to this patchset with v1 version.
>
> * In binding patch:
> * Invalid type of 'nand-rb' is fixed, it was 'bool', now it is 'uint32 array' as required. Also
> new declaration of 'nand-rb' contains several restrictions like number of elements and min/max
> value of elements.
> * Location of 'nand-rb' is moved from the controller object to the chip object as required.
Version your patchsets. This is v2, not v1.
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-06-07 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 14:50 [PATCH v1 0/2] Meson NAND: waiting w/o wired ready/busy pin Arseniy Krasnov
2023-06-07 14:50 ` [PATCH v1 1/2] dt-bindings: nand: meson: Fix 'nand-rb' property Arseniy Krasnov
2023-06-07 18:48 ` Krzysztof Kozlowski
2023-06-07 14:50 ` [PATCH v1 2/2] mtd: rawnand: meson: waiting w/o wired ready/busy pin Arseniy Krasnov
2023-06-07 15:50 ` Miquel Raynal
2023-06-07 15:18 ` [PATCH v1 0/2] Meson NAND: " Arseniy Krasnov
2023-06-07 18:48 ` Krzysztof Kozlowski [this message]
2023-06-07 18:58 ` Arseniy Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd2d1770-9856-d022-5e91-6a2cdc302b73@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avkrasnov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox