From: Marek Vasut <marek.vasut@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: xway: fix build failure
Date: Fri, 23 Dec 2016 10:07:23 +0100 [thread overview]
Message-ID: <c077e285-65e5-f66d-246c-aa58bd88f110@gmail.com> (raw)
In-Reply-To: <1482481032-28043-1-git-send-email-sudipm.mukherjee@gmail.com>
On 12/23/2016 09:17 AM, Sudip Mukherjee wrote:
> The build of mips xway_defconfig was failing with the error:
>
> drivers/mtd/nand/xway_nand.c:235:1: warning:
> data definition has no type or storage class
> MODULE_DEVICE_TABLE(of, xway_nand_match);
> ^~~~~~~~~~~~~~~~~~~
> drivers/mtd/nand/xway_nand.c:235:1: error:
> type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> [-Werror=implicit-int]
>
> It missed to include the header file.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Marek Vasut <marex@denx.de>
> ---
>
> Build log of next-20161223 is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/186246753
>
> This error will be fixed but it will now uncover the next error as the
> build goes on.
>
> drivers/mtd/nand/xway_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
> index 1f2948c..00168d6 100644
> --- a/drivers/mtd/nand/xway_nand.c
> +++ b/drivers/mtd/nand/xway_nand.c
> @@ -7,6 +7,7 @@
> * Copyright © 2016 Hauke Mehrtens <hauke@hauke-m.de>
> */
>
> +#include <linux/module.h>
> #include <linux/mtd/nand.h>
> #include <linux/of_gpio.h>
> #include <linux/of_platform.h>
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-12-23 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 8:17 [PATCH] mtd: nand: xway: fix build failure Sudip Mukherjee
2016-12-23 9:07 ` Marek Vasut [this message]
2016-12-29 16:28 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c077e285-65e5-f66d-246c-aa58bd88f110@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox