Re: [PATCH] spi-nor: intel-spi: Add support for Intel Ice Lake SPI serial flash

[Marek Vasut <marek.vasut@gmail.com>]

On 08/29/2018 12:33 PM, Boris Brezillon wrote:
> On Wed, 29 Aug 2018 10:28:05 +0000
> Joakim Tjernlund <Joakim.Tjernlund@infinera.com> wrote:
> 
>> On Wed, 2018-08-29 at 11:17 +0200, Boris Brezillon wrote:
>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
>>>
>>>
>>> Hi Marek,
>>>
>>> On Tue, 28 Aug 2018 18:56:38 +0200
>>> Marek Vasut <marek.vasut@gmail.com> wrote:
>>>   
>>>> On 08/28/2018 06:50 PM, Mika Westerberg wrote:  
>>>>> Intel Ice Lake exposes the SPI serial flash controller as a PCI device
>>>>> in the same way than Intel Denverton. Add Ice Lake SPI serial flash PCI
>>>>> ID to the driver list of supported devices.
>>>>>
>>>>> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>  
>>>>
>>>> This should probably go through trivial patches ML, no ?  
>>>
>>> Nope, it should go through the spi-nor tree. Actually, even for trivial
>>> fixes like typos, I prefer to take them directly to avoid possible
>>> future conflicts in case something changes near the typo.
>>>   
>>>> Also, CC Stable.  
>>>
>>> Why? It's adding a new entry in pci_ids[] table, it looks like
>>> supporting new HW to me, not fixing a bug.  
>>
>> So you can boot/use new HW with stable kernels. Stable kernels would become
>> useless fairly quickly otherwise.
>> HW enablement patches are OK when they don't affect existing HW by much.
> 
> Where did you get that from? I've always been told that Cc-ing stable
> was reserved for bug fixes.

Same rule applies to new USB IDs , it's an exception.

-- 
Best regards,
Marek Vasut