From: Alexander Amelkin <a.amelkin@yadro.com>
To: <linux-mtd@lists.infradead.org>
Cc: "Marek Vasut" <marek.vasut@gmail.com>,
openbmc@lists.ozlabs.org, "Joel Stanley" <joel@jms.id.au>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH] mtd: spi-nor: fix options for mx66l51235f
Date: Mon, 20 Aug 2018 13:26:51 +0300 [thread overview]
Message-ID: <c27b9cb1-33a1-221d-abd8-30050fe2b23b@yadro.com> (raw)
Currently in spi-nor driver there is a line for mx66l51235l.
According to Macronix site, there is no such part number. The chip
detected as such is actually mx66l51235f. Hence, this commit renames
the chip.
According to the datasheet for mx66l51235f, "The device default is in
24-bit address mode" (section 9-10). Having option SPI_NOR_4B_OPCODES
makes the code act as if the device was already in 4B mode and didn't
need the EN4B command. That prevents this chip from functioning on
systems where the boot loader left the chip in 3B mode (e.g. if the
chip wasn't used during the boot process).
Hence, this commit removes the SPI_NOR_4B_OPCODES option for
mx66l51235f (added previously by commit d342b6a973af).
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: <linux-mtd@lists.infradead.org>
Cc: <openbmc@lists.ozlabs.org>
Cc: Joel Stanley <joel@jms.id.au>
Fixes: d342b6a973af ("mtd: spi-nor: enable 4B opcodes for mx66l51235l")
Signed-off-by: Alexander Amelkin <a.amelkin@yadro.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index f028277..c5ef85e 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1091,7 +1091,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) },
{ "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
- { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+ { "mx66l51235f", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "mx66u51235f", INFO(0xc2253a, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
{ "mx66l1g45g", INFO(0xc2201b, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "mx66l1g55g", INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },
--
2.7.4
next reply other threads:[~2018-08-20 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 10:26 Alexander Amelkin [this message]
2018-08-27 10:33 ` [PATCH] mtd: spi-nor: fix options for mx66l51235f Marek Vasut
2018-08-27 11:24 ` Alexander Amelkin
2018-08-27 11:34 ` Marek Vasut
2018-08-28 11:29 ` Alexander Amelkin
2018-08-28 11:43 ` Marek Vasut
2018-08-28 15:54 ` Alexander Amelkin
2018-08-28 16:03 ` Marek Vasut
2018-08-29 11:00 ` Alexander Amelkin
2018-08-29 11:46 ` Marek Vasut
2018-08-29 12:12 ` Cédric Le Goater
2018-08-30 14:16 ` Cyrille Pitchen
2018-08-30 14:17 ` Marek Vasut
2018-08-29 12:05 ` Cédric Le Goater
2018-08-29 21:16 ` Roman Yeryomin
2018-08-31 8:04 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c27b9cb1-33a1-221d-abd8-30050fe2b23b@yadro.com \
--to=a.amelkin@yadro.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox