public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Cc: chris.packham@alliedtelesis.co.nz, boris.brezillon@bootlin.com,
	miquel.raynal@bootlin.com, thor.thayer@linux.intel.com,
	Marek Vasut <marex@denx.de>
Subject: [BUG] mtd: rawnand: mircon: Cannot detect chip with commit 51f3b3970a8c
Date: Fri, 6 Jul 2018 12:03:49 -0500	[thread overview]
Message-ID: <c3419bce-ecdb-b587-5e79-f75e34e7ef6c@kernel.org> (raw)

Hi,

It looks like commit: "51f3b3970a8c mtd: rawnand: micron: detect forced
on-die ECC" is causing the NAND chip on the SoCFPGA Arria10 devkit to
stop working on linux-next.

If I revert the commit, then the NAND driver is able to detect the NAND
chip.

The NAND chip is a Micron MT29F1G08ABBEAH4 part.


[    0.741984] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xa1
[    0.748336] nand: Micron MT29F1G08ABBEAH4
[    0.752330] nand: 128 MiB, SLC, erase size: 128 KiB, page size: 2048,
OOB siz
e: 64
 [    0.763358] ecc.mode = 3
[    0.766312] On-die ECC forcefully enabled, not supported
[    0.771654] denali-nand-dt: probe of ffb90000.nand failed with error -22

With commit reverted:

[    0.742481] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xa1
[    0.748833] nand: Micron MT29F1G08ABBEAH4
[    0.752828] nand: 128 MiB, SLC, erase size: 128 KiB, page size: 2048,
OOB siz
e: 64
[    0.760610] Bad block table found at page 65472, version 0x01
[    0.766433] Bad block table found at page 65408, version 0x01
[    0.772464] 2 fixed-partitions partitions found on MTD device denali-nand
[    0.779247] Creating 2 MTD partitions on "denali-nand":
[    0.784453] 0x000000000000-0x000001c00000 : "Boot and fpga data"
[    0.791241] 0x000001c00000-0x000008000000 : "Root Filesystem - JFFS2"

Looks like if I comment out this part of the patch in
drivers/mtd/nand/raw/nand_micron.c

+#if 0
        for (i = 0; i < ARRAY_SIZE(micron_on_die_ecc); i++)
                if (chip->id.data[1] == micron_on_die_ecc[i])
                        return MICRON_ON_DIE_MANDATORY;
-
+#endif

then the driver is able to detect the NAND chip again.

Dinh

             reply	other threads:[~2018-07-06 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 17:03 Dinh Nguyen [this message]
2018-07-06 17:20 ` [BUG] mtd: rawnand: mircon: Cannot detect chip with commit 51f3b3970a8c Boris Brezillon
2018-07-17 21:59   ` Chris Packham
2018-07-17 22:07     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3419bce-ecdb-b587-5e79-f75e34e7ef6c@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=boris.brezillon@bootlin.com \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=miquel.raynal@bootlin.com \
    --cc=thor.thayer@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox