From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156BCC433E6 for ; Wed, 20 Jan 2021 13:55:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B50BD23357 for ; Wed, 20 Jan 2021 13:55:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B50BD23357 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wsMQ+2S+6+GZPF7nE1qIcJvaCCWO4mGp1+clxrSXzh0=; b=ii9E1ZCgvEBQcL2p8khGjX4bb XZPWMURIgl1aUkaB6WtG8uTC9uJgbO5DY7TZmQSUa9pyziEu4F4y4TzvytJC/hVNM/XXUvIGb5FPG BuvSnBdjG6Eq9kSBU/Du8ciKz0jz3eymIV1SQf3QWQzX+A4SiDFrTYDBxafB/6kn2LqYDbohB20Ef DtTS6sfWQDEt4YbiEcLbwpv1tO3sk1DOSqPkZU7Fe78k1zjXEaBYDvd3WoDFMeazxDftbq87ffAoo bd53sl89K7p+cVxRWVb9bsx+YIXleG0Make9uMQslo5cE48TUlKV7HZsMjB9hDY+5rc6S4jVr3KNj dhe2+4pSg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2Dwm-0006Cy-Ab; Wed, 20 Jan 2021 13:54:56 +0000 Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2Dwf-0006A1-2r for linux-mtd@lists.infradead.org; Wed, 20 Jan 2021 13:54:53 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id CDD3922727; Wed, 20 Jan 2021 14:54:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1611150885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cl0hy++h0E1NlJAISb8N0+U8zEIekjiaQOS7rsZtXGQ=; b=VAV7i0Sz2RnF0v400l1Pq+NCHtsyuImEgVDPflySCo7gND5vdQIBiayV423j7i8z/BFGsV ml4c7vhKA/syIRvhm3qVFZb6s+kQpwpvePmd/JX3DFhq8gBUvTR4t++gxMk5BlMCXoEYl5 al664btMcPHHyNg08ZGQ9PNr29ZT7ek= MIME-Version: 1.0 Date: Wed, 20 Jan 2021 14:54:44 +0100 From: Michael Walle To: Tudor Ambarus Subject: Re: [PATCH v2 1/2] mtd: spi-nor: Add Global Block Unlock command In-Reply-To: <20210120131914.277363-1-tudor.ambarus@microchip.com> References: <20210120131914.277363-1-tudor.ambarus@microchip.com> User-Agent: Roundcube Webmail/1.4.10 Message-ID: X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_085449_905075_A851BCFF X-CRM114-Status: GOOD ( 21.41 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, richard@nod.at, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Kavyasree.Kotagiri@microchip.com, miquel.raynal@bootlin.com, p.yadav@ti.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Am 2021-01-20 14:19, schrieb Tudor Ambarus: > The Global Block Unlock command has different names depending > on the manufacturer, but always the same command value: 0x98. > Macronix's MX25U12835F names it Gang Block Unlock, Winbound's Winbond > W25Q128FV names it Global Block Unlock and Microchip's > SST26VF064B names it Global Block Protection Unlock. > > Used in the Individual Block Protection mode, which is mutually > exclusive with the Block Protection mode (BP0-3). > > Signed-off-by: Tudor Ambarus > Reviewed-by: Pratyush Yadav Reviewed-by: Michael Walle -michael > --- > v2: > - s/mutual/mutually/ > - set the GBULK cmd buswidth to 0 and call spi_nor_spimem_setup_op() > to update the it, because the op can can be issued in QPI mode as well. > - add Pratyush's R-b tag > > drivers/mtd/spi-nor/core.c | 37 +++++++++++++++++++++++++++++++++++++ > drivers/mtd/spi-nor/core.h | 1 + > include/linux/mtd/spi-nor.h | 1 + > 3 files changed, 39 insertions(+) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index 20df44b753da..e82732dd31e1 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -853,6 +853,43 @@ int spi_nor_wait_till_ready(struct spi_nor *nor) > DEFAULT_READY_WAIT_JIFFIES); > } > > +/** > + * spi_nor_global_block_unlock() - Unlock Global Block Protection. > + * @nor: pointer to 'struct spi_nor'. > + * > + * Return: 0 on success, -errno otherwise. > + */ > +int spi_nor_global_block_unlock(struct spi_nor *nor) > +{ > + int ret; > + > + ret = spi_nor_write_enable(nor); > + if (ret) > + return ret; > + > + if (nor->spimem) { > + struct spi_mem_op op = > + SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_GBULK, 0), > + SPI_MEM_OP_NO_ADDR, > + SPI_MEM_OP_NO_DUMMY, > + SPI_MEM_OP_NO_DATA); > + > + spi_nor_spimem_setup_op(nor, &op, nor->reg_proto); > + > + ret = spi_mem_exec_op(nor->spimem, &op); > + } else { > + ret = spi_nor_controller_ops_write_reg(nor, SPINOR_OP_GBULK, > + NULL, 0); > + } > + > + if (ret) { > + dev_dbg(nor->dev, "error %d on Global Block Unlock\n", ret); > + return ret; > + } > + > + return spi_nor_wait_till_ready(nor); > +} > + > /** > * spi_nor_write_sr() - Write the Status Register. > * @nor: pointer to 'struct spi_nor'. > diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h > index d631ee299de3..eb26796db026 100644 > --- a/drivers/mtd/spi-nor/core.h > +++ b/drivers/mtd/spi-nor/core.h > @@ -434,6 +434,7 @@ int spi_nor_write_disable(struct spi_nor *nor); > int spi_nor_set_4byte_addr_mode(struct spi_nor *nor, bool enable); > int spi_nor_write_ear(struct spi_nor *nor, u8 ear); > int spi_nor_wait_till_ready(struct spi_nor *nor); > +int spi_nor_global_block_unlock(struct spi_nor *nor); > int spi_nor_lock_and_prep(struct spi_nor *nor); > void spi_nor_unlock_and_unprep(struct spi_nor *nor); > int spi_nor_sr1_bit6_quad_enable(struct spi_nor *nor); > diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h > index d13958de6d8a..a0d572855444 100644 > --- a/include/linux/mtd/spi-nor.h > +++ b/include/linux/mtd/spi-nor.h > @@ -53,6 +53,7 @@ > #define SPINOR_OP_WREAR 0xc5 /* Write Extended Address Register */ > #define SPINOR_OP_SRSTEN 0x66 /* Software Reset Enable */ > #define SPINOR_OP_SRST 0x99 /* Software Reset */ > +#define SPINOR_OP_GBULK 0x98 /* Global Block Unlock */ > > /* 4-byte address opcodes - used on Spansion and some Macronix > flashes. */ > #define SPINOR_OP_READ_4B 0x13 /* Read data bytes (low frequency) */ ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/