From: "Andrew Victor" <avictor.za@gmail.com>
To: "Haavard Skinnemoen" <haavard.skinnemoen@atmel.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] atmel_nand: Work around AT32AP7000 ECC errata
Date: Sun, 22 Jun 2008 16:54:10 +0200 [thread overview]
Message-ID: <cd73a99e0806220754v5cbbbeefm1c0a47ef25431391@mail.gmail.com> (raw)
In-Reply-To: <1213948112-22348-2-git-send-email-haavard.skinnemoen@atmel.com>
hi Haavard,
> The ALE signal isn't correctly wired up to the ECC controller on the
> AP7000, so it starts calculating ECC during the address cycles.
Shouldn't affect the AT91's, so
Acked-by: Andrew Victor <linux@maxim.org.za>
You might want to also change/remove the comment where the ECC hwctl()
function is registered.
It's currently:
nand_chip->ecc.hwctl = at91_nand_hwctl; /* unused */
Regards,
Andrew Victor
next prev parent reply other threads:[~2008-06-22 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 7:48 [PATCH 1/3] atmel_nand speedup via {read,write}s{b,w}() Haavard Skinnemoen
2008-06-20 7:48 ` [PATCH 2/3] atmel_nand: Work around AT32AP7000 ECC errata Haavard Skinnemoen
2008-06-20 7:48 ` [PATCH 3/3] MTD: atmel_nand can be modular Haavard Skinnemoen
2008-06-22 14:55 ` Andrew Victor
2008-06-22 14:54 ` Andrew Victor [this message]
2008-06-22 14:50 ` [PATCH 1/3] atmel_nand speedup via {read,write}s{b,w}() Andrew Victor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd73a99e0806220754v5cbbbeefm1c0a47ef25431391@mail.gmail.com \
--to=avictor.za@gmail.com \
--cc=dwmw2@infradead.org \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox