Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'

Artem Bityutskiy
2009-11-10T14:20:52Z

On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> >> index 090ab87..92573d5 100644
> >> --- a/drivers/mtd/nand/omap2.c
> >> +++ b/drivers/mtd/nand/omap2.c
> >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> >> mtd_info *mtd, u_char
> >
> > :-) It is the same again.
> >
> > Try to send the e-mail to yourself, then save it and apply with git-am.
> > If it works, send to the mailing list.
>
> Below patch applies. Sorry for noise... :(
>
> Thanks,
> vimal
>
>
> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 090ab87..92573d5 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> const u_char *buf, int len)
> {
> + u_char *p = (u_char *)buf;
> +
> if (len <= mtd->oobsize)
> - omap_write_buf_pref(mtd, buf, len);
> + omap_write_buf_pref(mtd, p, len);
> else
> /* start transfer in DMA mode */
> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> + omap_nand_dma_transfer(mtd, p, len, 0x1);
> }

I think that you should instead remove the 'const' modifier from the
'omap_write_buf_dma_pref()' function. Indeed, if it has the 'const'
modifier, it should never change the bugger.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)