Re: [RFC] mtd: spinand: Add initial support for Toshiba TC58CVG2S0F

[Schrempf Frieder <frieder.schrempf@kontron.de>]

On 27.11.18 16:07, Clément Péron wrote:
> On Tue, 27 Nov 2018 at 15:59, Clément Péron <peron.clem@gmail.com> wrote:
>>
>> Hi Frieder,
>>
>> On Tue, 27 Nov 2018 at 15:47, Schrempf Frieder
>> <frieder.schrempf@kontron.de> wrote:
>>>
>>> Hello Clément,
>>>
>>> On 27.11.18 14:59, Clément Péron wrote:
>>>> Add support for Toshiba chip TC58CVG2S0F
>>>>
>>>> Signed-off-by: Clément Péron <peron.clem@gmail.com>
>>>> ---
>>>>
>>>> Hi,
>>>>
>>>> Thanks a lot for adding this framework to Linux it's very nice and easy to read.
>>>>
>>>> This is my first SPI Nand/Nand board so I'm still unfamiliar with those BBM and OOB features.
>>>>
>>>> In the ECC status maybe I should return the Maximum Bit Flip Count (page 34 of the DS) like it's done for Macronix.
>>>>
>>>> Datasheet could be found here: https://media.digikey.com/pdf/Data%20Sheets/Toshiba%20PDFs/TC58CVG2S0HxAIx_Rev1.1_2016-11-08.pdf
>>>>
>>>>
>>>> Also this has not been fully tested and untested with a QuadSPI controller.
>>>
>>> I'm afraid there is a big overlap between your patch and what I posted
>>> some days ago. See here: Patchwork [1] or linux-next [2].
>>>
>>> Please have a look at my patch and test it with your hardware. You seem
>>> to use the same chip as I am (except for the last letter in the part
>>> number, whose meaning I don't know).
>>
>> Thanks for pointing that,
>>
>> I'm not a linux-mtd subscriber could you reply and add my e-mail to your patch ?
> Or maybe as it has already been merged maybe I should write a new
> e-mail with my remark no ?

Hm, I'm not sure. I have sent a copy of the original patch to you. I 
guess you can still reply with your comments and we will see how to deal 
with them.

If there are any issues, please let us know so we can apply fixes on top 
of the current patch.

Thanks,
Frieder