Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema

[Akhila YS <akhilayalmati@gmail.com>]

On 02-01-2026 13:47, Akhila YS wrote:
>
>
> On 30-12-2025 18:02, Krzysztof Kozlowski wrote:
>> On Mon, Dec 29, 2025 at 12:49:00PM +0000, Akhila YS wrote:
>>> +---
>>> +$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Microchip 23K256 (and similar) SPI SRAM MTD driver
>> driver? Bindings are for hardware.
>
>
> Sure, I will fix it.
>
>>> +
>>> +maintainers:
>>> +  - Richard Weinberger <richard@nod.at>
>>> +
>>> +description: |
>> Do not need '|' unless you need to preserve formatting.
> Ok.
>>> +  Driver for Microchip 23K256 and compatible (e.g. 23LCV1024) serial SRAM devices
>> Don't describe drivers...
>>
>>> +  accessed via SPI. The device exposes the SRAM as an MTD device and supports
>>> +  optional partitioning via child nodes.
>> nor DTS, but the hardware.
>
>
> OK, I will change it.
>
>>> +
>>> +allOf:
>>> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
>>> +
>> If this is SRAM, then it should go to sram directory. But maybe it is
>> MTD, so NOR or NAND? If so you would be missing here refs to NAND
>> chips.
>>
>> Although docs are saying it is SRAM, so just place it there.
>
> This SRAM is not generic MMIO SRAM, it's an SPI peripheral exposing
> memory via the MTD subsystem. Also i tried Yaml from sram directory it
> doesn't work with it.
>
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - microchip,mchp23k256
>>> +      - microchip,mchp23lcv1024
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  "#address-cells":
>>> +    const: 1
>>> +
>>> +  "#size-cells":
>>> +    const: 1
>> Pretty incomplete. Old binding and above cells claim there can be child
>> nodes, so please add them and test. Works? No. Shall work? Yes... so
>> either old binding was incorrect or new binding is incomplete. I did not
>> check the driver, though.
>
>
> Size cells and Address cells are not required as there is no child
> node and I tried to define child node , Included SRAM.Yaml as a
> reference file and tested it. It doesn't work.
>
>>> +
>>> +required:
>>> +  - reg
>>> +  - compatible
>>> +  - "#address-cells"
>>> +  - "#size-cells"
>>> +  - spi-max-frequency
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    spi {
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        sram@0 {
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>> They are redundant. Where are children?
>
>
> They are redundant, There is no child node  and i will remove it.
>
>>> +            compatible = "microchip,mchp23k256";
>>> +            reg = <0>;
>>> +            spi-max-frequency = <20000000>;
>>> +        };
>>> +    };
>>> +...
>>>
>>> ---
>>> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
>>> change-id: 20251229-nxp-526e29da9f29
>>>
>>> Best regards,
>>> -- 
>>> Akhila YS <akhilayalmati@gmail.com>
>>>
-- 
Best Regards,
Akhila.


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/