From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDEAC433FF for ; Wed, 31 Jul 2019 13:07:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E267206B8 for ; Wed, 31 Jul 2019 13:07:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F+IkZjjJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="mdRrR3GK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E267206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PS8rVTVWdTCdTqheRV2BWGC2WkgwuEb6CecK5AjiW+M=; b=F+IkZjjJCdUBSL Qw28aT1mkfG5a2znPznR/6rpqun2YhsptrCmGToIVe6oqIEn6xEhrdr36uoIPAxWFZ735IwPJnxb+ dtOclboJBPG7y8jUd77kxTsYCNqj7NGV9tH+url0wYKb+E4WXV10v43ltZ+UidBmV5s48CG7r6Y8F RDASZaVUwBmQVdW5oHFusWDPxFwV/TnYbX++aKjKfvvYFaT8tqFuDCnAU+828mU2USfJhBcYHFgj2 t3K6Z6y7oxQwnop/S9ySXjGE4qalSdkf9tGKv4Trjq8xqkXmVyYzQtQDDQa3yhIKiyG2/4FCXbVaq WAO6EwM9fPK7wOp0RJog==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsoJm-0004Pj-Qn; Wed, 31 Jul 2019 13:06:58 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsoJh-0004Og-Ka for linux-mtd@lists.infradead.org; Wed, 31 Jul 2019 13:06:57 +0000 Received-SPF: Pass (esa4.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa4.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa4.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa4.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa4.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: 3Bk5g0SioaS+ab2CxA2sF4JJ3qs/8dZOYCMIDjlZRab8yAkuofDivSarHDHVV4DxwU6DgPZqTd JTIY8ji/Mz15XAGERMSpDJ7US92BobFKnWTDuXZub8q8VXMCyGgf6n52A11tCpnZUUtIMFCA2K UgOe42hy/CvXfx8HhmrWpjMSYndrS7YMVv0LVOq4pVS6qngMsEPGVXKP7GtVlhHyLxjT5R5/dB JoRh/t/iUxeA0CJ3zZ7c8TxVL9DLZwOJAtWpwmc5kIqAKgFioQ+EDyny4yocO4WTpbJI7I5Fja 6bI= X-IronPort-AV: E=Sophos;i="5.64,330,1559545200"; d="scan'208";a="42656730" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 31 Jul 2019 06:06:48 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 31 Jul 2019 06:06:46 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 31 Jul 2019 06:06:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ObwHP3pb0T1HS5gypDUHsGDaEZomf9MBYabqxXslWXHwKR5qDA0Wwrw1s0QE14HHXkC/7Vwn0pVy7uEXf587QvdEyUkcoxFaZNN6p77zoYd3dK24NU//Lr607KKq+3xN2Y6VSNOjYG9vaWTa//l6GwuMC2AiFmygAI08PHBTK7r683QXGCsvkR1t+lDxFPvBoC02WvxHQN8gYO3k1O3kumPz6Q+ZiAu0ctZi+ObiPGYJc0sai0dOUlu8I6EgntcyWcPuz82P6wqLUhWWqy+ISqIq2t9dwTmyDkS2lQzBnbvVEyo1wPonf4y0FD4SDxSH3FMRvqdoJSnUsg0HpI01zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DzrPid35fjCOw3EkXeoph/i9Wv+vr9lZc8pr58BleKo=; b=Cfu+XjK9iBtAc14UtX6oeKVKyirVmwDsmG4i5wqgApSzkSdfp2yTiLQ4EorXho/QPXePFrQ1dpREPuIZao/Pa+42ldhU86UWDHh2+GIJVUGClqUKqhO3DzdeR6DkPIiZe4d7NUYCqTM1Av7nukpC2f/QDd6pT4kir3R76SOlFxoRdGHIUDb9Sb5Bja3xnQiQT4UUh2DaHVYrxSJRv9KCbyyQSgPTsQXcswbuYe8jTyYUBB0oE86fLh8gHAMJcnvMPz7szqdn5afx6vfLf0dZBdfvtifNtJXzbR/diuFtyolZqMYR+wosaNnO8WtgbC+FXFEDuO4WrbtJThIHPZ7+kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=microchip.com;dmarc=pass action=none header.from=microchip.com;dkim=pass header.d=microchip.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DzrPid35fjCOw3EkXeoph/i9Wv+vr9lZc8pr58BleKo=; b=mdRrR3GKXlsujCpcAvycnVlQMUqgec8kZtPA4cqUXDmX6auuq0qzwjReCYtmVXEbL7jj0deWKSWnaCT6BR+3MOaD+Txj/yauWuqQPnUROm0/6swdNcIjIeEToW0hYTU3UMjKHhUazczX5BoYk6c+CWtztwndUWiQT5pc7k8bUh8= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB3711.namprd11.prod.outlook.com (20.178.254.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Wed, 31 Jul 2019 13:06:46 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::61d1:6408:89a2:8de5]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::61d1:6408:89a2:8de5%2]) with mapi id 15.20.2115.005; Wed, 31 Jul 2019 13:06:46 +0000 From: To: , , , Subject: Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() Thread-Topic: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() Thread-Index: AQHVR4AMaH6Ddp0nkEGsW9FcCZCHs6bkqLWAgAAJ2wA= Date: Wed, 31 Jul 2019 13:06:45 +0000 Message-ID: References: <20190731091145.27374-1-tudor.ambarus@microchip.com> <20190731091145.27374-6-tudor.ambarus@microchip.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MR2P264CA0052.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::16) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0549b613-59c2-4423-606b-08d715b7f096 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB3711; x-ms-traffictypediagnostic: MN2PR11MB3711: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 011579F31F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(346002)(396003)(366004)(39860400002)(199004)(189003)(52116002)(4326008)(7736002)(316002)(6116002)(8936002)(6486002)(86362001)(25786009)(53546011)(3846002)(71200400001)(31696002)(54906003)(6246003)(8676002)(966005)(305945005)(71190400001)(478600001)(5660300002)(6436002)(66066001)(6306002)(14454004)(2501003)(68736007)(6506007)(386003)(2201001)(110136005)(64756008)(486006)(66476007)(66446008)(66556008)(186003)(6512007)(31686004)(446003)(81166006)(99286004)(2616005)(4744005)(476003)(11346002)(256004)(81156014)(102836004)(7416002)(76176011)(2906002)(26005)(66946007)(229853002)(53936002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3711; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: MO02jVNxFq7CS8RRBHFe2roKMMXMyivH+6TTQEDgTNhdicxtbJe5mT0RBREnQRpqLulhAsvyBTJdg/yIMp89m01evyJ4Tb3sPCaD2g4aHNlzPUU7+ReKAdrgTSA+Aux1dEpq6ZdZhKWzGsX+X/FTVrRsl/s9saGP59sYg6h0xWZURycjDOICHn8DDFMcImjDQcVGKdHuLfrbRkBnWn8c6+qYMWoQ4W0hQAJPXRt/eWB2E5E9oETvduZjAMGkQtZ4/hw6GfW25hUz7j4O/y2YrLuJLiw7eyYvKhekeCwM7e0Ze3v5/2iYa1z/FF9rqBKHoCj9Q7ODHGdkUOcNVnOfWqD9mWc27cytaQ17yDoP4wUFJXeFbFIuvFJeOLn/WrIC/iAALCFDSowTg6+gq+bEperdwoPbmMwB6q4+oGz8MFE= Content-ID: <9C5BA27FD850E84E9261E407CB6C7352@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0549b613-59c2-4423-606b-08d715b7f096 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2019 13:06:45.6790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tudor.ambarus@microchip.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3711 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190731_060653_765205_17CD16B6 X-CRM114-Status: UNSURE ( 7.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard@nod.at, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi, Naga, On 07/31/2019 03:31 PM, Naga Sureshkumar Relli wrote: >> + if (nor->info->flags & SPI_S3AN) >> + s3an_post_sfdp_fixups(nor); >> } >> > Instead of checking the flags, why can't we call directly the nor_fixups? > like Boris implementation nor->info->fixups->post_sfdp() > https://patchwork.ozlabs.org/patch/1009291/ This check will vanish and nor->info->fixups->post_sfdp() will be called directly once I'll respin the manufacturer driver part. post_sfdp() will set just flash parameters. Check Boris' patch at https://patchwork.ozlabs.org/patch/1009295/ I'll try to respin the rest of Boris' patches sometime at the beginning of the next week. Cheers, ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/