Re: [PATCH v3 4/4] mtd: mxc_nand: generate nand_ecclayout for 8 bit ECC

Baruch Siach
2015-05-21T04:11:28Z

Hi Brian,

On Wed, May 20, 2015 at 03:41:20PM -0700, Brian Norris wrote:
> On Wed, May 13, 2015 at 11:17:39AM +0300, Baruch Siach wrote:
> > + if (get_eccsize(mtd) == 8)
> > + ecc_8bit_layout_4k(this->ecc.layout);
>
> So you're overwriting an existing layout (e.g., nandv2_hw_eccoob_4k).
> What if you have more than one NAND chip? You might do better by
> dynamically allocating the memory.

It would take a quite a bit more code changes then that to have the mxc_nand
driver support more than one NAND chip, not to mention the DT binding. As Uwe
has indicated on a previous version of this series, ecclayout handling in this
driver could use some cleanup. This patch just fixes bug, trying to break
anything else while doing so.

Thanks for reviewing, and for applying the rest of this series.

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -