From: "Rafał Miłecki" <rafal@milecki.pl>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Scott Branden" <scott.branden@broadcom.com>
Subject: Re: [PATCH] nvmem: brcm_nvram: store a copy of NVRAM content
Date: Thu, 14 Sep 2023 10:02:47 +0200 [thread overview]
Message-ID: <d0545951a0e787792c5cc20eca66a72a@milecki.pl> (raw)
In-Reply-To: <3f175090-4c5f-4821-9155-06c4868d0489@arinc9.com>
On 2023-09-14 09:56, Arınç ÜNAL wrote:
> On 14.09.2023 09:49, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This driver uses MMIO access for reading NVRAM from a flash device.
>> Underneath there is a flash controller that reads data and provides
>> mapping window.
>>
>> Using MMIO interface affects controller configuration and may break
>> real
>> controller driver. It was reported by multiple users of devices with
>> NVRAM stored on NAND.
>>
>> Modify driver to read & cache all NVRAM content during init and use
>> that
>> copy to provide NVMEM data when requested.
>>
>> Link:
>> https://lore.kernel.org/linux-mtd/CACna6rwf3_9QVjYcM+847biTX=K0EoWXuXcSMkJO1Vy_5vmVqA@mail.gmail.com/
>> Cc: Arınç ÜNAL <arinc.unal@arinc9.com>
>> Cc: Florian Fainelli <florian.fainelli@broadcom.com>
>> Cc: Scott Branden <scott.branden@broadcom.com>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> This is a bug fix, could you add a "Fixes" tag so it will be backported
> to
> stable releases?
I suppose we could try:
Fixes: 3fef9ed0627a ("nvmem: brcm_nvram: new driver exposing Broadcom's
NVRAM")
Srini: can you append it while applying if you find it OK?
--
Rafał Miłecki
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-09-14 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 6:49 [PATCH] nvmem: brcm_nvram: store a copy of NVRAM content Rafał Miłecki
2023-09-14 7:56 ` Arınç ÜNAL
2023-09-14 8:02 ` Rafał Miłecki [this message]
2023-09-14 21:26 ` Florian Fainelli
2023-09-14 21:30 ` Scott Branden
2023-09-15 7:28 ` Rafał Miłecki
2023-09-15 9:08 ` Scott Branden
2023-09-15 7:25 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0545951a0e787792c5cc20eca66a72a@milecki.pl \
--to=rafal@milecki.pl \
--cc=arinc.unal@arinc9.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=scott.branden@broadcom.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox