From: Stefan Agner <stefan@agner.ch>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: vigneshr@ti.com, richard@nod.at, marek.vasut@gmail.com,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH] mtd: rawnand: vf610_nfc: Add of_node_put() before goto
Date: Tue, 09 Jul 2019 20:54:05 +0200 [thread overview]
Message-ID: <d28641662420b0a10fbf2a238a3dd056@agner.ch> (raw)
In-Reply-To: <20190709170837.13315-1-nishkadg.linux@gmail.com>
On 2019-07-09 19:08, Nishka Dasgupta wrote:
> Each iteration of for_each_available_child_of_node puts the previous
> node, but in the case of a goto from the middle of the loop, there is no
> put, thus causing a memory leak. Hence add an of_node_put before the
> goto.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Looks good to me:
Reviewed-by: Stefan Agner <stefan@agner.ch>
--
Stefan
> ---
> drivers/mtd/nand/raw/vf610_nfc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c
> index e4fe8c4bc711..6b399a75f9ae 100644
> --- a/drivers/mtd/nand/raw/vf610_nfc.c
> +++ b/drivers/mtd/nand/raw/vf610_nfc.c
> @@ -862,6 +862,7 @@ static int vf610_nfc_probe(struct platform_device *pdev)
> dev_err(nfc->dev,
> "Only one NAND chip supported!\n");
> err = -EINVAL;
> + of_node_put(child);
> goto err_disable_clk;
> }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-07-09 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:08 [PATCH] mtd: rawnand: vf610_nfc: Add of_node_put() before goto Nishka Dasgupta
2019-07-09 18:54 ` Stefan Agner [this message]
2019-07-25 7:55 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d28641662420b0a10fbf2a238a3dd056@agner.ch \
--to=stefan@agner.ch \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nishkadg.linux@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox