public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: liao jaime <jaimeliao.tw@gmail.com>,
	linux-mtd@lists.infradead.org, pratyush@kernel.org,
	miquel.raynal@bootlin.com, leoyu@mxic.com.tw,
	jaimeliao@mxic.com.tw
Subject: Re: [PATCH v6 5/7] spi: mxic: Add support for swapping byte
Date: Thu, 07 Dec 2023 13:39:28 +0100	[thread overview]
Message-ID: <d754407b5e7a6cbe58ac3ac4af8e1acc@walle.cc> (raw)
In-Reply-To: <d32f9632-7d03-4a78-9bf9-622de518cb28@linaro.org>

Hi,

> I know for sure that mchp's sama7g5 xSPI controller can swap the bytes
> back on the fly. What I did was to check the dtr_swab16 bool at runtime
> in the exec_op() method and if it was true, I had to write a
> configuration bit. I can't remember why I haven't posted a v2 on that
> series, maybe I'll do it if I find some time or I ever get bored. I 
> have
> a board. Anyway, knowing that there's a board out there, sama7g5ek, 
> that
> contains a macronix flash that swaps bytes and also have a controller
> that can swap them back, would it be acceptable to queue just the SPI
> NOR patches for now?

I'm still leaning towards not putting any unused code into the kernel
and (maybe) increase maintenance. Or code which might need to be 
adjusted
later if it will actually be used. Without a user, we won't see the
whole picture and - at least I - cannot judge whether that approach is
correct then.

I'd say, if you ever get board, take this patch again together with the
user :)

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2023-12-07 12:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30  8:38 [PATCH v6 0/7] Add octal DTR support for Macronix flash Jaime Liao
2023-11-30  8:38 ` [PATCH v6 1/7] mtd: spi-nor: add Octal " Jaime Liao
2023-11-30  8:38 ` [PATCH v6 2/7] spi: spi-mem: Allow specifying the byte order in DTR mode Jaime Liao
2023-11-30  8:38 ` [PATCH v6 3/7] mtd: spi-nor: core: " Jaime Liao
2023-11-30  8:38 ` [PATCH v6 4/7] mtd: spi-nor: sfdp: Get the 8D-8D-8D byte order from BFPT Jaime Liao
2023-11-30  8:38 ` [PATCH v6 5/7] spi: mxic: Add support for swapping byte Jaime Liao
2023-11-30  9:11   ` Michael Walle
2023-12-01  1:42     ` liao jaime
2023-12-01  8:25       ` Michael Walle
2023-12-04  6:44         ` liao jaime
2023-12-04  7:35           ` Tudor Ambarus
2023-12-07 12:39             ` Michael Walle [this message]
2023-12-12  7:44               ` liao jaime
2023-11-30  8:38 ` [PATCH v6 6/7] mtd: spi-nor: add support for Macronix Octal flash with RWW feature Jaime Liao
2023-11-30  8:38 ` [PATCH v6 7/7] mtd: spi-nor: add support for Macronix Octal flash Jaime Liao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d754407b5e7a6cbe58ac3ac4af8e1acc@walle.cc \
    --to=michael@walle.cc \
    --cc=jaimeliao.tw@gmail.com \
    --cc=jaimeliao@mxic.com.tw \
    --cc=leoyu@mxic.com.tw \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox