Re: [v5 PATCH 11/14] xfrm: ipcomp: Use crypto_acomp interface

Herbert Xu
2025-04-25T13:16:18Z

On Fri, Apr 25, 2025 at 02:11:44PM +0200, Sabrina Dubroca wrote:
>
> The splat goes away with
>
> /* Only update truesize on input. */
> if (!hlen)
> - skb->truesize += dlen - plen;
> + skb->truesize += dlen;
> skb->data_len = dlen;
> skb->len += dlen;
>
> pskb_trim_unique ends up calling skb_condense, which seems to adjust
> the truesize to account for all frags being dropped.
>
> Does that look like the right fix to you?

You're right. I must've missed the truesize update in skb_condense
when writing this.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt