Re: [PATCH] new NOR flash winbond w25q16jv, jedec code 0xef7015

[Marek Vasut <marek.vasut@gmail.com>]

On 05/25/2018 04:48 PM, Johannes Poehlmann wrote:
> Copy values from jedec code 0xef4015, which is also the jedec code
> of Winbond w25q16db. w25q16jv is presented as follow up type in the
> data sheet. w25q16jv works with this patch.
> 
> Signed-off-by: Johannes Poehlmann <johannes.poehlmann@izt-labs.de>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 5bfa36e..9bac67b 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1188,6 +1188,7 @@ static const struct flash_info spi_nor_ids[] = {
>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>  	},
> +	{ "w25q16jv", INFO(0xef7015, 0, 64 * 1024,  32, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

What about HAS_LOCK and HAS_TB ? Looks good otherwise.

>  	{ "w25x32", INFO(0xef3016, 0, 64 * 1024,  64, SECT_4K) },
>  	{ "w25q20cl", INFO(0xef4012, 0, 64 * 1024,  4, SECT_4K) },
>  	{ "w25q20bw", INFO(0xef5012, 0, 64 * 1024,  4, SECT_4K) },
> 


-- 
Best regards,
Marek Vasut