From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Rabara, Niravkumar L" <niravkumar.l.rabara@intel.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [bug report] mtd: rawnand: cadence: use dma_map_resource for sdma address
Date: Thu, 13 Feb 2025 12:50:34 +0300 [thread overview]
Message-ID: <e25c59ea-341a-464f-976f-885be234ce12@stanley.mountain> (raw)
In-Reply-To: <BL3PR11MB65325337C3F6BBAD406F6E36A2FF2@BL3PR11MB6532.namprd11.prod.outlook.com>
On Thu, Feb 13, 2025 at 07:33:49AM +0000, Rabara, Niravkumar L wrote:
>
> I missed this.
> I will add a NULL check before the dma_unmap_resource()
>
> if (cdns_ctrl->dmac)
> dma_unmap_resource(cdns_ctrl->dmac->device->dev, cdns_ctrl->io.iova_dma,
> cdns_ctrl->io.size, DMA_BIDIRECTIONAL, 0);
>
> Shall I submit a new version of this patch?
> Do I need to include any additional tag or info?
I don't really know how it's handled in mtd.
Generally, I would send a patch just to fix the bug. You would want to
have a Fixes tag and a Reported-by tag. Some subsystems fold fixes into
the original commit before sending and some don't. Either way, the
maintainer can figure it out.
regards,
dan carpenter
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2025-02-13 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 7:13 [bug report] mtd: rawnand: cadence: use dma_map_resource for sdma address Dan Carpenter
2025-02-13 7:33 ` Rabara, Niravkumar L
2025-02-13 9:50 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e25c59ea-341a-464f-976f-885be234ce12@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=niravkumar.l.rabara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox