Re: [PATCH 7/7] mtd: spi-nor: hisi-sfc: Simplify with scoped for each OF child loop

Krzysztof Kozlowski
2026-01-03T12:38:51Z

On 02/01/2026 14:33, Pratyush Yadav wrote:
> Hi Kyzystof,
>
> Thanks for the cleanup.
>
> On Fri, Jan 02 2026, Krzysztof Kozlowski wrote:
>
>> Use scoped for-each loop when iterating over device nodes to make code a
>> bit simpler.
>
> Nit: the commit message is a bit too dry. I had to go and look what the
> difference between the two variants was. I could make an educated guess
> by looking at the patch, but still.

Really? That's old and widely used syntax, replaced so many times and
sorry, but really obvious.

We should not explain core kernel API in commit msgs, except maybe first
months of usage.

>
> If you end up doing a v2, a one-liner explanation of the difference
> between the two loop variants would be nice to have.

Best regards,
Krzysztof