Re: [PATCH 7/7] mtd: spi-nor: hisi-sfc: Simplify with scoped for each OF child loop

Pratyush Yadav
2026-01-02T13:34:13Z

Hi Kyzystof,

Thanks for the cleanup.

On Fri, Jan 02 2026, Krzysztof Kozlowski wrote:

> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.

Nit: the commit message is a bit too dry. I had to go and look what the
difference between the two variants was. I could make an educated guess
by looking at the patch, but still.

If you end up doing a v2, a one-liner explanation of the difference
between the two loop variants would be nice to have.

Acked-by: Pratyush Yadav <pratyush@kernel.org>

>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/mtd/spi-nor/controllers/hisi-sfc.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/hisi-sfc.c b/drivers/mtd/spi-nor/controllers/hisi-sfc.c
> index db948da2c4c5..54c49a8423a2 100644
> --- a/drivers/mtd/spi-nor/controllers/hisi-sfc.c
> +++ b/drivers/mtd/spi-nor/controllers/hisi-sfc.c
> @@ -394,15 +394,12 @@ static void hisi_spi_nor_unregister_all(struct hifmc_host *host)
> static int hisi_spi_nor_register_all(struct hifmc_host *host)
> {
> struct device *dev = host->dev;
> - struct device_node *np;
> int ret;
>
> - for_each_available_child_of_node(dev->of_node, np) {
> + for_each_available_child_of_node_scoped(dev->of_node, np) {
> ret = hisi_spi_nor_register(np, host);
> - if (ret) {
> - of_node_put(np);
> + if (ret)
> goto fail;
> - }
>
> if (host->num_chip == HIFMC_MAX_CHIP_NUM) {
> dev_warn(dev, "Flash device number exceeds the maximum chipselect number\n");

--
Regards,
Pratyush Yadav